fivetran / dbt_snapchat_ads

Fivetran data models for Snapchat Ads built using dbt.
https://fivetran.github.io/dbt_snapchat_ads
Apache License 2.0
1 stars 6 forks source link

Bug/creative #10

Closed fivetran-reneeli closed 2 years ago

fivetran-reneeli commented 2 years ago

Pull Request Are you a current Fivetran customer?

Internal

What change(s) does this PR introduce?

Remove creative id from the ad adapter model. Previously we brought in creative_id into the ad adapter model, but snapchat metrics only deliver at the ad_id level and ads may have more than one creative. Therefore this potentially over-attributed metrics to a creative and caused duplicates for metrics like spend and impression.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.