search

fivetran / dbt_snapchat_ads

Fivetran data models for Snapchat Ads built using dbt.
https://fivetran.github.io/dbt_snapchat_ads
Apache License 2.0
1 stars 6 forks source link

Updated ad_account_id test severity to warn #20

Closed bthomson22 closed 4 months ago

bthomson22 commented 9 months ago

Please provide your name and company Brandon Thomson

Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_snapchat_ads/issues/16

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. This updates the test severity for the ad_account_id not_null test to warn.

How did you validate the changes introduced within this PR? Checked out my version in a clean project with Snapchat source data and ran dbt build -s snapchat_ads__account_report:

Before: Screenshot 2023-11-20 at 11 16 17 PM

After: Screenshot 2023-11-20 at 11 23 13 PM

Which warehouse did you use to develop these changes? Google BigQuery

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
fivetran-jamie commented 4 months ago

hey @bthomson22 this looks great! just going to merge this into a release branch and update some doc-related minutiae and then we'll push this out to main!