fivetran / dbt_snapchat_ads

Fivetran data models for Snapchat Ads built using dbt.
https://fivetran.github.io/dbt_snapchat_ads
Apache License 2.0
1 stars 6 forks source link

Releases/v0.6.latest #24

Closed fivetran-jamie closed 6 months ago

fivetran-jamie commented 6 months ago

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_snapchat_ads/issues/16 (also contains merged PR https://github.com/fivetran/dbt_snapchat_ads/pull/20)

This PR will result in the following new package version:

v0.6.2

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

Under the Hood

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

Confirmed working by @bthomson22, but i also recreated the issue in a somewhat hacky way by

  1. running the package as normal

  2. updating the stg_snapchat_ads__ad_account_history to have null account IDs

  3. running dbt run -m snapchat_ads__account_report without the code update

  4. dbt test -m snapchat_ads__account_report -- produces failure without adjusting severity image

  5. dbt test again after updating the not_null test to be a warning (did so in Ad Reporting as well) image

If you had to summarize this PR in an emoji, which would it be?

⚠️