This PR will result in the following new package version:
v0.6.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
Adjust the severity of the ad_account_id test in snapchat_ads__account_report to warn. This is required since Snapchat can hard-delete records from the history tables, but not from the reporting tables. This ensures that accurate statistics are being reported and production pipelines aren't failing. (PR #20)
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_snapchat_ads/issues/16 (also contains merged PR https://github.com/fivetran/dbt_snapchat_ads/pull/20)
This PR will result in the following new package version:
v0.6.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
ad_account_id
test insnapchat_ads__account_report
towarn
. This is required since Snapchat can hard-delete records from the history tables, but not from the reporting tables. This ensures that accurate statistics are being reported and production pipelines aren't failing. (PR #20)Under the Hood
Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Confirmed working by @bthomson22, but i also recreated the issue in a somewhat hacky way by
running the package as normal
updating the
stg_snapchat_ads__ad_account_history
to have null account IDsrunning
dbt run -m snapchat_ads__account_report
without the code updatedbt test -m snapchat_ads__account_report
-- produces failure without adjusting severitydbt test
again after updating the not_null test to be a warning (did so in Ad Reporting as well)If you had to summarize this PR in an emoji, which would it be?
⚠️