search

fivetran / dbt_snapchat_ads_source

Fivetran's Snapchat Ads source dbt package
https://fivetran.github.io/dbt_snapchat_ads_source/
Apache License 2.0
1 stars 4 forks source link

[Feature] Add disabling models for non-existent sources #14

Open kirk-dave opened 2 years ago

kirk-dave commented 2 years ago

Is there an existing feature request for this?

Describe the Feature

We (Dave.com) launch campaigns on Snapchat, but do no use creative url tags. This causes this package to fail (see below) since the creative_url_tag_history table does not exist in the schema managed by the Snapchat connector.

Please add a config to disable models for non-existent sources (specifically creative_url_tag_history). For example, the Fivetran Stripe package has this currently:

Screen Shot 2022-08-25 at 10 24 56 AM

14:33:03  Database Error in model stg_snapchat__creative_url_tag_history_tmp (models/tmp/stg_snapchat__creative_url_tag_history_tmp.sql)
14:33:03    002003 (42S02): SQL compilation error:
14:33:03    Object 'MARKETING_DB.SNAPCHAT_ADS_V2.CREATIVE_URL_TAG_HISTORY' does not exist or not authorized.
14:33:03    compiled SQL at target/run/snapchat_ads_source/models/tmp/stg_snapchat__creative_url_tag_history_tmp.sql
14:33:03  Encountered an error:
FailFast Error in model stg_snapchat__creative_url_tag_history_tmp (models/tmp/stg_snapchat__creative_url_tag_history_tmp.sql)
Failing early due to test failure or runtime error
Error: Process completed with exit code 2.

Describe alternatives you've considered

Have worked w. our Fivetran AE & support to find alternatives. They recommended requesting this feature.

Are you interested in contributing this feature?

Anything else?

No response

fivetran-joemarkiewicz commented 1 year ago

Hi @kirkbrunson-dave thanks so much for opening this ticket and my apologies that it has taken our team longer than expected to look into this ticket.

I believe this is a doable feature request and I could see others benefiting from the ability to disable the url tag source if they are not using it. In addition to disabling the models within the staging package, we would also want to disable its downstream uses. It seems the main use is within our creative prep intermediate model. Disabling the linked CTE shouldn't be too much of a lift or cause issues for others.

Our team will scope this out further and plan to bring the update into a future sprint. We will post back here with more details once we start working on the feature.