fivetran / dbt_stripe

Data models for Stripe built using dbt.
https://fivetran.github.io/dbt_stripe/
Apache License 2.0
30 stars 31 forks source link

feature/databricks-compatibility #44

Closed fivetran-joemarkiewicz closed 1 year ago

fivetran-joemarkiewicz commented 1 year ago

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

Databricks compatibility 🧱

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Same as the source, since there was a breaking change only a while ago it would not make sense to do a breaking change here as well.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

🧱 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 1 year ago

Hey @fivetran-joemarkiewicz, everything looks good to me. I just had the same question I had in the source - and a reminder to update packages.yml before release as you've already commented for yourself :)

Do you intend to keep those stripe_* schema names for integration_tests/ci/sample.profiles.yml?

Thanks @fivetran-sheringuyen great call out, just updating those now!