fivetran / dbt_stripe

Data models for Stripe built using dbt.
https://fivetran.github.io/dbt_stripe/
Apache License 2.0
30 stars 31 forks source link

Adding the invoice.currency column to invoice_line_items #47

Closed ccbrandenburg closed 1 year ago

ccbrandenburg commented 1 year ago

Pull Request Are you a current Fivetran customer? Christopher Brandenburg, Gigs (gigs.com), Head of Data

What change(s) does this PR introduce? The stripe__invoice_line_items.sql model was missing the invoice's currency.

The currency is available further upstream of the model in stg_stripe__invoice and I have added the field plus the description.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:cyclone: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-joemarkiewicz commented 1 year ago

@ccbrandenburg also FYI my team and I will be attending the Coalesce Conference next week and will be having a release freeze in place until we get back. You can expect this change to go live the week of 10/24.

Thanks again so much for your contribution!!

fivetran-joemarkiewicz commented 1 year ago

In the meantime, we are good to merge these changes!