Closed fivetran-reneeli closed 1 year ago
@fivetran-jamie so this is ready for review save for the error on databricks which i think is related to how i added null to price_id and plan_id in stg_stripe__pricing
in the opposite source table CTEs as an additional field, to help the unique tests pass in the stg_stripe__pricing
. So I'm still thinking through how to go about this
looks pretty good to me! just spotted a couple of places where we need to update the price variable name (though i suppose this will be merged with the other PR where you already did that 🤷 )
Thanks @fivetran-jamie yeah it doesn't hurt, I added your changes in 👍
Are you a current Fivetran customer?
Internal What change(s) does this PR introduce?
pricing
source table which may replace theplan
table depending on whether customer migrated to the Price API (some column names have changed in stripe__invoice_line_items)Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.