Closed fivetran-reneeli closed 1 year ago
Note on stripe__subscription_line_items
stripe__subscription_line_items
I was thinking of just deleting this model since it's just taking invoice data and filtering for just those with a subscription id, so it's not that useful for customers. Further more we already have a stripe__subscription_details
model. Hi @fivetran-jamie this is ready for review. This branch contains updates for the following
invoice details
and account daily overview
(with new int_stripe__account_daily
and int_stripe__date_spine
)invoice line items
Note on stripe__subscription_line_items
stripe__subscription_line_items
I was thinking of just deleting this model since it's just taking invoice data and filtering for just those with a subscription id, so it's not that useful for customers. Further more we already have a stripe__subscription_details
model.Lmk if you have any questions!
looks good to me! only addition i'd make is to the changelog -- maybe add the code for how they could essentially recreate the deleted stripe__subscription_line_items
model
Are you a current Fivetran customer?
Internal What change(s) does this PR introduce?
stripe__invoice_details
andstripe__account_daily_overview
stripe__invoice_line_items
with pricing data andsubscription_item_id
stripe__subscription_line_items
modelDid you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
union_feature
branchIs this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.