search

fivetran / dbt_stripe

Data models for Stripe built using dbt.
https://fivetran.github.io/dbt_stripe/
Apache License 2.0
32 stars 34 forks source link

fix!: handle multiple disputes #88

Closed bramrodenburg closed 1 month ago

bramrodenburg commented 1 month ago

Please provide your name and company

Bram - Gigs

Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_stripe/issues/87

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.

Although it happens rarely (see here), a payment can be disputed more than once. The existing balance_transactions model cannot handle this scenario. In this PR, that is fixed by aggregating the dispute_[id/reason/amount] before joining the dispute data back.

How did you validate the changes introduced within this PR?

Followed the steps here and built the dbt_stripe package against our data.

Which warehouse did you use to develop these changes?

BigQuery

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?

If you had to summarize this PR in an emoji, which would it be?

🥸 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
bramrodenburg commented 1 month ago

Would you be able to create a CHANGELOG.md entry for these changes? Since this will be changing field names, we will need to make this a breaking change (v0.15.0).

Makes sense. Will do.