fivetran / dbt_stripe_source

Fivetran's Stripe source dbt package
https://fivetran.github.io/dbt_stripe_source/
Apache License 2.0
8 stars 27 forks source link

Added timezone to column description #42

Closed mvtemple closed 2 years ago

mvtemple commented 2 years ago

Pull Request Are you a current Fivetran customer? Ephemeral Tattoos.

What change(s) does this PR introduce? Add timezone notation to timestamp column. Should replicate for all timestamp columns for clarity.

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-reneeli commented 2 years ago

Hey @mvtemple thanks again for opening this up. I went ahead and cleared away the rest of the changes needed; once our tests pass we'll go ahead and merge to main!

fivetran-reneeli commented 2 years ago

This has been merged with https://github.com/fivetran/dbt_stripe_source/pull/45

mvtemple commented 2 years ago

Thank you Renee!!!

On Tue, Jun 21, 2022 at 10:42 AM Renee Li @.***> wrote:

This has been merged with #45 https://github.com/fivetran/dbt_stripe_source/pull/45

— Reply to this email directly, view it on GitHub https://github.com/fivetran/dbt_stripe_source/pull/42#issuecomment-1161841143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT36FYD4JMLQ7TNO2NC6KEDVQHIDPANCNFSM5YURFDLQ . You are receiving this because you were mentioned.Message ID: @.***>