Closed fivetran-joemarkiewicz closed 1 year ago
Hey @fivetran-joemarkiewicz, awesome work on adding spark compatibility! Everything looks great, just had one clarifying question but PR looks good for approval.
I only had one question - do you intend to keep those
stripe_*
schema names forintegration_tests/ci/sample.profiles.yml
?
Ahh I do not! Thanks for catching that. Updating now.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Databricks compatibility 🧱
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
This Databricks compatibility will not be breaking. While it will be a big update, I don't think it warrants a breaking change since we just came off another one not too long ago.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🧱 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.