[Feature] Add status columns to the invoice table

fivetran / dbt_stripe_source

Fivetran's Stripe source dbt package

https://fivetran.github.io/dbt_stripe_source/

Apache License 2.0

8 stars 30 forks source link

[Feature] Add status columns to the invoice table #53

Closed lijol closed 1 year ago

lijol commented 2 years ago

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature

The below columns to be added STATUS_TRANSITIONS_FINALIZED_AT STATUS_TRANSITIONS_PAID_AT STATUS_TRANSITIONS_VOIDED_AT STATUS_TRANSITIONS_MARKED_UNCOLLECTIBLE_AT

Describe alternatives you've considered

None

Are you interested in contributing this feature?

[X] Yes.
[ ] Yes, but I will need assistance and will schedule time during your office hours for guidance.
[ ] No.

Anything else?

No response

lijol commented 2 years ago

Let me know if I can go ahead and raise PR on this change

fivetran-joemarkiewicz commented 2 years ago

Hi @lijol thanks for creating this feature request! Which source table are you looking to add these fields to?

lijol commented 2 years ago

stg_stripe__invoice

fivetran-joemarkiewicz commented 2 years ago

Hi @lijol I apologize for the delayed response. It looks like we have those columns already in our get_invoice_columns macro! https://github.com/fivetran/dbt_stripe_source/blob/3a51c3f2097597be7b838081a367bcf77d900912/macros/get_invoice_columns.sql#L40-L43

Therefore, adding these to the final staging model would not be too risky as others should already have them. I would be happy to review a PR introducing these fields if you were open to creating another PR 😄

fivetran-reneeli commented 1 year ago

Hi @lijol thank you for raising this ticket! We have updated the invoice table to include these fields. As such I will close this issue!