search

fivetran / dbt_stripe_source

Fivetran's Stripe source dbt package
https://fivetran.github.io/dbt_stripe_source/
Apache License 2.0
8 stars 27 forks source link

update readme to include how to use metadata variable dictionary arguments #57

Closed fivetran-reneeli closed 1 year ago

fivetran-reneeli commented 1 year ago

Pull Request Are you a current Fivetran customer?

internal What change(s) does this PR introduce?

update readme to include how to use metadata variable dictionary arguments Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-reneeli commented 1 year ago

@fivetran-joemarkiewicz ready for re review

fivetran-reneeli commented 1 year ago

@fivetran-reneeli the condensed update looks great. I did have one last suggestion I would like for you to apply to the README before merging. Let me know if you have any questions around my final suggestion.

I like your addition of the "variable accepts dictionary and strings", but for purposes of people scanning and looking at the variables, I think it is best to be consistent with how they should declare the variables.

Makes sense to keep it standard to not raise any confusion. Changes applied!