Closed fivetran-joemarkiewicz closed 1 year ago
Hey @fivetran-joemarkiewicz, thanks for working on this PR! I've made a couple in-line notes and had one extra thing -- I think this is a change that will warrant a docs regeneration.
Thanks @fivetran-sheringuyen just addressed the review notes! I also did wonder if this would require a docs regen; however, the only user side change is where we are doing the renaming of interval
to plan_interval
the only difference is the renaming is happening in the fields
cte as opposed to the final
cte of the stg_stripe__plan model. Therefore, the docs wouldn't be affected.
However, now that I say that.... the code still changed 😮💨 I'll regen the docs.
Sweet! LGTM, as long as Buildkite passes we should be good to go
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Under the Hood
plan_interval
field within thestg_stripe__plan
model has been aliased within theget_plan_columns()
macro to allow for more flexibility across warehouses.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
This is strictly an under the hood update and will not cause a breaking change for existing users.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🚙 **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.