fivetran / dbt_stripe_source

Fivetran's Stripe source dbt package
https://fivetran.github.io/dbt_stripe_source/
Apache License 2.0
8 stars 27 forks source link

Stripe updates #59

Closed fivetran-reneeli closed 1 year ago

fivetran-reneeli commented 1 year ago

Are you a current Fivetran customer?

Internal

What change(s) does this PR introduce?

Q4 Stripe updates

Did you update the CHANGELOG?

Does this PR introduce a breaking change?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

Select which warehouse(s) were used to test the PR

Provide an emoji that best describes your current mood

:dancer: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next.
fivetran-reneeli commented 1 year ago

Hi @fivetran-joemarkiewicz thanks for your review! I made a few updates accordingly and have rebased to a new branch feature/stripe-updates-q4-2022. I also finished adding the changelog and readme. Finally I also added timestamp casts to the respective fields in staging models. There are a few erroring out with "cannot cast INT to timestamp". So far I've checked that the columns are indeed timestamps both in the source data and the get-columns macros, so still working on it

fivetran-reneeli commented 1 year ago

Timestamp issue resolved