This PR will address the following Issue/Feature: #63
This PR will result in the following new package version:v0.9.2
This is only changing the uniqueness test of the stg_stripe__fee model. Additionally, as this model is not used in any downstream transformations, I feel extra confident that this will not result in a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR is an extension of the contributor PR #64
This PR includes a new field index being added to the stg_stripe__fee model. This field was already included in the get_fee_columns macro and the seed files. As such, this was a relatively easy addition to the staging model. This field was primarily added to ensure we can appropriately test the unique combination of columns for the fee staging model. As a fee can have multiple indexes, we need to account for this accordingly within our package.
Additionally, you can see in our own Stripe ERD that index is included in the composite PK. As such, we should account for this accordingly.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[X] dbt compile
[X] dbt run –full-refresh
[X] dbt run
[X] dbt test
[X] dbt run –vars (if applicable)
Before marking this PR as “ready for review” the following have been applied:
[X] The appropriate issue has been linked and tagged
[X] You are assigned to the corresponding issue and this PR
[x] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:
[X] You have validated these changes and assure this PR will address the respective Issue/Feature.
[X] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
In addition to running the compile, run, and test commands, I also tested these changes along with the current live version of the dbt_stripe package to ensure there would be no downstream impacts. As the stg_stripe__fee model is not connected to any downstream models, I am very confident this will not caused any issues. Additionally, I was able to verify from the docs and our own ERD that index should in fact be counted towards the uniqueness of the fee staging model.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[X] indexed within dbt_project.yml
[X] indexed within integration_tests/dbt_project.yml
[X] CHANGELOG has individual entries for each respective change in this PR
[X] README updates have been applied (if applicable)
[X] DECISIONLOG updates have been updated (if applicable)
[X] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[X] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: #63
This PR will result in the following new package version:
v0.9.2This is only changing the uniqueness test of the
stg_stripe__feemodel. Additionally, as this model is not used in any downstream transformations, I feel extra confident that this will not result in a breaking change.Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR is an extension of the contributor PR #64
This PR includes a new field
indexbeing added to thestg_stripe__feemodel. This field was already included in theget_fee_columnsmacro and the seed files. As such, this was a relatively easy addition to the staging model. This field was primarily added to ensure we can appropriately test the unique combination of columns for the fee staging model. As a fee can have multiple indexes, we need to account for this accordingly within our package.Additionally, you can see in our own Stripe ERD that index is included in the composite PK. As such, we should account for this accordingly.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as “ready for review” the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:
In addition to running the compile, run, and test commands, I also tested these changes along with the current live version of the dbt_stripe package to ensure there would be no downstream impacts. As the
stg_stripe__feemodel is not connected to any downstream models, I am very confident this will not caused any issues. Additionally, I was able to verify from the docs and our own ERD that index should in fact be counted towards the uniqueness of the fee staging model.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🐾