fivetran / dbt_xero

Data models for Fivetran's Xero connector built using dbt.
https://fivetran.github.io/dbt_xero/#!/overview
Apache License 2.0
10 stars 20 forks source link

[Bug] Unrealised Currency Gains not reported #48

Open brandonrf94 opened 5 months ago

brandonrf94 commented 5 months ago

Is there an existing issue for this?

Describe the issue

Xero reports unrealised currency gains, similar to quickbooks - but this transformation does not include the calcuation.

I noticed in the ReadMe history there was a mention about this but that mention was removed, can you confirm if unrealised gains/losses should be captured or not?

Relevant error log or model output

n.a

Expected behavior

Unrealsied gains should be available on the P&L

dbt Project configurations

Open invoices/bills should capture unrealised gains/losses in the transformation

Package versions

Using quickstart

What database are you using dbt with?

snowflake

dbt Version

Quickstart

Additional Context

No response

Are you willing to open a PR to help address this issue?

fivetran-avinash commented 5 months ago

Hi @brandonrf94, at this moment we cannot capture unrealized currency gains, as we would need to know what the currency exchange rates are for each transaction. This is not something that is available within the Xero connector ERD. Without it, we can't work backward to understand what the gains or losses are. More details are here in the "Note about currency gains" section of the README.

I see you created a support ticket within Fivetran regarding this being a Transformations issue. This is actually a connector issue, as we would need those exchange rates available within the ERD schema to bring into our data models and then provide unrealized currency gains in the final models.

I'd recommend updating your Fivetran support request for an update in the Xero connector to include exchange rates, and once that's provided, we can work on adding support for unrealized gains.

Hope that helps!