fivetran / dbt_zendesk

Fivetran's Zendesk Support dbt package
https://fivetran.github.io/dbt_zendesk/#!/overview
Apache License 2.0
25 stars 30 forks source link

Business hours + schedule holiday fixes #114

Closed fivetran-jamie closed 8 months ago

fivetran-jamie commented 9 months ago

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

v0.12.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

Lots of validation via slack with the @cth84 for business minutes

I've also compared our internal zendesk data before-and-after (calendar minutes only) and everything except the total_reply_time_calendar_minutes is tying out (there are 26 tickets that are off). shared the exact query i used for this in Slack.

I have not compared the sla_policy metrics however, as I imagine @fivetran-reneeli's changes will be affect things there.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

If you had to summarize this PR in an emoji, which would it be?

☠️
fivetran-joemarkiewicz commented 8 months ago

Duplicate SLA fixes have been rolled into this branch so we may roll them out together as they both were reliant on the other updates.