This PR will address the following Issue/Feature: Issue #117
This PR will result in the following new package version:v0.13.0
This will not result in breaking changes to the current users as it will only adjust the holiday times to properly be converted into their respective UTC comps. This will only adjust and patch a previous error to some schedule and holiday overlaps. As a result this will not be a breaking change.
However, this will be merged into a branch that does include a breaking upstream change. As such, we will want to make this a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Bug Fixes
Updates the int_zendesk__schedule_spine model to convert the Holiday schedules into proper UTC values before being used in comparison with the schedule times. This ensures the holidays are properly mapped to schedules regardless of timezones.
Under the Hood
Corrected the folder structure for the .github folder to properly categorize the Community and Maintainer PR templates.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[X] dbt compile
[X] dbt run –full-refresh
[X] dbt run
[X] dbt test
[X] dbt run –vars (With schedules both on and off)
Before marking this PR as "ready for review" the following have been applied:
[X] The appropriate issue has been linked and tagged
[X] You are assigned to the corresponding issue and this PR
[X] BuildKite integration tests are passing
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
[x] You have validated these changes and assure this PR will address the respective Issue/Feature.
[x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
[X] You have provided details below around the validation steps performed to gain confidence in these changes.
To test these changes I performed the following validation efforts.
I adjusted a sample schedule to have the hours of the schedule approach the end of the day.
For that schedule, I then inspected the holidays that are set for the schedule. For this validation I focused on the Craig Day.
I then checked the current live version of the Zendesk package and was able to observe that due to the schedule hours breaching over into the next day (when factoring in the UTC offset) I can see that our holiday logic does not take into account the fact that one of these days in the schedule period is a holiday. This is due to the UTC offset breaching into the next day and not being caught in our holiday_name_check logic.
Then when inspecting the end results of the int_zendesk__schedule_spine model we can see that the holiday for Craig Day is still included in the schedule period. The expected results here would be that the day is excluded so the business hours aren't counted towards that holiday.
However, when testing this branch, we can see that Craig Day is captured in the holiday_name_check logic and in the end query for the int_zendesk__schedule_spine model the day is properly omitted as the holiday is being taken into consideration and hours are not counted on that holiday.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
Package versioning has been appropriately indexed in the following locations:
[X] indexed within dbt_project.yml
[X] indexed within integration_tests/dbt_project.yml
[X] CHANGELOG has individual entries for each respective change in this PR
[n/a] README updates have been applied (if applicable)
[n/a] DECISIONLOG updates have been updated (if applicable)
[n/a] Appropriate yml documentation has been added (if applicable)
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
[will be generated in combined release branch] docs were regenerated (unless this PR does not include any code or yml updates)
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: Issue #117
This PR will result in the following new package version:
v0.13.0This will not result in breaking changes to the current users as it will only adjust the holiday times to properly be converted into their respective UTC comps. This will only adjust and patch a previous error to some schedule and holiday overlaps. As a result this will not be a breaking change.
However, this will be merged into a branch that does include a breaking upstream change. As such, we will want to make this a breaking change.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Bug Fixes
int_zendesk__schedule_spinemodel to convert the Holiday schedules into proper UTC values before being used in comparison with the schedule times. This ensures the holidays are properly mapped to schedules regardless of timezones.Under the Hood
.githubfolder to properly categorize the Community and Maintainer PR templates.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
To test these changes I performed the following validation efforts.
Craig Day.holiday_name_checklogic.int_zendesk__schedule_spinemodel we can see that the holiday forCraig Dayis still included in the schedule period. The expected results here would be that the day is excluded so the business hours aren't counted towards that holiday.Craig Dayis captured in theholiday_name_checklogic and in the end query for theint_zendesk__schedule_spinemodel the day is properly omitted as the holiday is being taken into consideration and hours are not counted on that holiday.Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📆