It was discovered that some tickets were not persisting through the final sla policies model, and mistakenly filtered out at the int_zendesk__reply_time_combined model.
This PR will result in the following new package version:
v0.13.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
Updated the int_zendesk__reply_time_combined model to account for when a ticket is first replied to outside SLA schedules or not yet replied to.
Under the Hood
Adjusted the filter used in the filtered_reply_times CTE for business hours to account for the aforementioned cases, as these records were mistakenly being filtered out previously.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
[x] dbt run –full-refresh && dbt test
[ ] dbt run (if incremental models are present) && dbt test
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[ ] Detailed validation steps have been provided below
tested with internal data, validations linked in height ticket
Detailed Validation
Please share any and all of your validation steps:
Confirmed the missing tickets were showing up prior to the int_zendesk__reply_time_combined model, and confirmed they are in fact expected to exist in the end models and not be filtered out. Then adjusted the filters in the filtered reply times CTE, ran the package, and confirmed that the tickets persisted in the end sla policies model.
If you had to summarize this PR in an emoji, which would it be?
PR Overview
This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_zendesk/issues/131
It was discovered that some tickets were not persisting through the final
sla policies
model, and mistakenly filtered out at theint_zendesk__reply_time_combined
model.This PR will result in the following new package version:
v0.13.2
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
int_zendesk__reply_time_combined
model to account for when a ticket is first replied to outside SLA schedules or not yet replied to.Under the Hood
filtered_reply_times
CTE for business hours to account for the aforementioned cases, as these records were mistakenly being filtered out previously.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
[x] The appropriate issue has been linked, tagged, and properly assigned
[x] All necessary documentation and version upgrades have been applied
[x] docs were regenerated (unless this PR does not include any code or yml updates)
[x] BuildKite integration tests are passing
[ ] Detailed validation steps have been provided below
tested with internal data, validations linked in height ticket
Detailed Validation
Please share any and all of your validation steps:
int_zendesk__reply_time_combined
model, and confirmed they are in fact expected to exist in the end models and not be filtered out. Then adjusted the filters in thefiltered reply times
CTE, ran the package, and confirmed that the tickets persisted in the endsla policies
model.If you had to summarize this PR in an emoji, which would it be?
:calendar: