fivetran / dbt_zendesk_source

Fivetran's Zendesk Support source dbt package
https://fivetran.github.io/dbt_zendesk_source/#!/overview
Apache License 2.0
13 stars 18 forks source link

[0.4.0] Upgrade to dbt v0.20 #16

Closed jtcohen6 closed 3 years ago

jtcohen6 commented 3 years ago

(same basic story as https://github.com/fivetran/dbt_hubspot_source/pull/46)

Are you a current Fivetran customer? Jeremy Cohen, dbt Labs, yes!

What change(s) does this PR introduce?

Does this PR introduce a breaking change?

Is this PR in response to a previously created Issue

How did you test the PR changes?

- [ ] CircleCi - [ ] Other (please provide additional testing details below) **Select which warehouse(s) were used to test the PR** - [ ] BigQuery - [ ] Redshift - [ ] Snowflake - [x] Postgres - [ ] Databricks - [ ] Other (provide details below) I ran this on Postgres, everything passed, with one tiny change: I needed to wrap quotes around the `default` column in `brand_data`, since `default` is a reserved word in Postgres. ``` dbt deps dbt seed dbt run dbt test ``` As before, happy to run against the other warehouses if you'd like. With an update like this, if the package parses/compiles/runs right on one, it ought to across the board. **Provide an emoji that best describes your current mood** 🕴️ 🕴️
jtcohen6 commented 3 years ago

I realize I accidentally included an edit to integration_tests/data/brand_data.csv that wrapped a column named default in quotes. This was needed to run integration tests on Postgres locally, but it doesn't make sense to include as part of this PR.