search

fivetran / dbt_zuora_source

Data models for Fivetran's Zuora source package, built using dbt.
https://fivetran.github.io/dbt_zuora_source/
Apache License 2.0
1 stars 2 forks source link

review/jm-initial #1

Closed fivetran-joemarkiewicz closed 1 year ago

fivetran-joemarkiewicz commented 1 year ago

This PR is not intended to be merged, but rather acts as an initial review of the first build of the package. Please see the comments below for any notes to apply to the main branch prior to the initial release.

fivetran-joemarkiewicz commented 1 year ago

Thanks for addressing the review notes @fivetran-avinash! I was able to resolve most and responded to the remaining ones. Let me know if you have any final questions when addressing the final notes.

Additionally, in regards to the seed data configs the defaults are pretty consistent with what you provided. However, there can sometimes be cases where we need to adjust a bit more based on the target.type. Although those are usually case by case.