fivetran / dbt_zuora_source

Data models for Fivetran's Zuora source package, built using dbt.
https://fivetran.github.io/dbt_zuora_source/
Apache License 2.0
1 stars 2 forks source link

Use quotes for order table #6

Closed raphaelvarieras closed 1 year ago

raphaelvarieras commented 1 year ago

Please provide your name and company Raphael from Zello

Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_zuora/issues/6

Detail what changes this PR introduces and how this addresses the issue/feature request linked above. This is an easy fix that worked for me but not sure how to implement in a way that is more adapter-independent.

How did you validate the changes introduced within this PR? dbt Cloud run was successful.

Which warehouse did you use to develop these changes? Snowflake

Did you update the CHANGELOG?

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

Provide an emoji that best describes your current mood

:confused: **Feedback** We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your [feedback](https://www.surveymonkey.com/r/DQ7K7WW) on our existing dbt packages or what you'd like to see next. **PR Template** - [Community Pull Request Template](?expand=1&template=pull_request_template.md) (default) - [Maintainer Pull Request Template](?expand=1&template=maintainer_pull_request_template.md) (to be used by maintainers)
raphaelvarieras commented 1 year ago

Makes total sense @fivetran-joemarkiewicz - I just wasn't quite sure how to go about it!

fivetran-joemarkiewicz commented 1 year ago

@raphaelvarieras thanks for making the update! Would you also be able to add a corresponding reference in the README section about changing the identifier variables.

image

Once that is updated and the CHANGELOG has been updated this should be good to go!