search

fivexl / terraform-aws-cloudtrail-to-slack

Parse AWS CloudTrail events and send alerts to Slack for events that match pre-configured rules
https://registry.terraform.io/modules/fivexl/cloudtrail-to-slack/aws/latest
Apache License 2.0
93 stars 26 forks source link

Custom rules separator #25

Closed admssa closed 2 years ago

admssa commented 2 years ago

In order to be able to use more complex rules. Some rules may contain commas but rules_as_list = rules_as_string.split(',') split it and break.

Andrey9kin commented 2 years ago

@admssa Thanks for the pull request! Doing separator configurable is definitely a good idea. Though there are two distinct changes bundled together in the same pull request. One is configurable separators and another one is a non-backward compatible change in the interface. Would it be too much trouble to submit a configurable separator as a separate pull request? We will merge it straight away. As for the interface change. Yes, it is better to have it as a list of strings but at the same time, I would prefer keeping the old variable (that takes input as a string) in place and marking it deprecated mean while providing a new way to provide rules a list of strings. In this way, we give people time to prepare for the change while not blocking upgrades to the new versions. What do you think?

admssa commented 2 years ago

@Andrey9kin Updated. Kept the separator only.

Andrey9kin commented 2 years ago

@admssa perfect! Thanks!

admssa commented 2 years ago

@Andrey9kin Thank you for the fast response.

Andrey9kin commented 2 years ago

available in 3.1.0