search

fixlr / codemirror-rails

Use CodeMirror with Rails
https://rubygems.org/gems/codemirror-rails
MIT License
159 stars 87 forks source link

Rails 5.0 #50

Closed BookOfGreg closed 8 years ago

BookOfGreg commented 8 years ago

Extension to @NickLaMuro 's PR #49 This gets the dummy Rails 5 folder in test into the same style as the others and working (Well, I'll let Travis be the judge of that)

BookOfGreg commented 8 years ago

Hmm, not sure what to make of the Rails 3.2 on Ruby 2.3 error in Travis, I thought it was Test Unit related but adding it to the Gemfile for Rails 3.2 didn't seem to fix it. Anyone have any thoughts on that?

NickLaMuro commented 8 years ago

@BookOfGreg Thanks for the PR, I kinda gave up on the tests after a bit last night because I saw that they have been failing on master. The changes you made totally make sense and explain why I was going insane last night :)

I think I have a theory that it might be a bundler upgrade issue as the change between master being green and being red was a pretty benign change from what I could tell. I will merge in your changes into my branch (locally for now, because as it stands, your PR is in much better shape than mine), and try that out.

Thanks again!

fixlr commented 8 years ago

Merged with https://github.com/fixlr/codemirror-rails/pull/49