fixposition / fixposition_driver

ROS Driver for Fixposition Vision-RTK 2 Visual Inertial GNSS Positioning Sensor
MIT License
45 stars 38 forks source link

Missing error handling #30

Closed floriansegginger closed 7 months ago

floriansegginger commented 1 year ago

The constructor of the FixpositionDriver class does not check the return value of the Connect() method.

https://github.com/fixposition/fixposition_driver/blob/main/fixposition_driver_lib/src/fixposition_driver.cpp#L31

As such, the only way to know if the connection was successful when using this class, is to call RunOnce() and check the return value of that.

Maybe the constructor could throw an exception when connection fails?