Rail(with datamap) loading incorrect.

CacPixel commented 1 year ago

Before submitting a bug, please make sure following checks.

[x] You have finished loading all model packs before login to world/server.
[X] You're using the latest stable, snapshot, or daily-snapshot version of fixRTM.
[X] You're using correct version of RTM and NGTLib for your fixRTM.
[X] You couldn't find same bag in the issues.

Descrive the bug

When riding a train on rails, entering a new chunk, loading a rail with datamap, the rail may disappear. At this time,

rail model cannot load.
player can't click mouse wheel to get item.
player can stand on the rail.
if the rail contains height, player will stuck on rails just like you're standing on a ghost block in a laggy server. (I don't know how to describe this. Say it directly, it's the red line when editing LINE1 of a marker)
rtm:large_rail_base is shown on debug screen (F3).
when player re-enter the chunk, add/remove subrail (right click) or replace the rail (shift+right click), all things become regularly.

Video: https://user-images.githubusercontent.com/31470772/210702330-e9ba5a71-a056-4535-8fe4-269256ba71ad.mp4

It seems that the server and client are not synchronized. As tested, when a rail contains datamap with 3 items (one of them was Double and 2 of them was Int), this bug occur. I used datamap a lot in the video, so the chance to reproduce the bug is much higher. Screenshot_2023-01-04_23-29-04

Datamap shown in .mca files: Screenshot_2023-01-04_23-33-28

Screenshot_2023-01-04_23-32-45

r.-7.-18.mca.zip

To Reproduce

This bug occurs randomly. I can't predict when it will occur. The way to reproduce is running back and forth on rails with datamap, and waiting for the bug occur. If needed, I can provide the save folder and modelpack.

Expected Behavior

Rails loading correctly, all models appears.

Actual Behavior

See video.

OS

Win10 21H2

Minecraft Forge Version

2859

fixRTM Version

2.0.24 (also verified in 2.0.23, or build manually from source)

Other Mods

optifine, worldedit, chiselsandbits, malisisdoors, openterraingenerator(not used at this moment, I use superflat), voxelmap, vanillafix, aperture, blockbuster, minema, metamorph, soundlimitextends, surge, worldeditcui

CacPixel commented 1 year ago

Screenshot_2023-01-05_13-26-15

anatawa12 commented 1 year ago

Can you give me the log file (if exists, debug log is better) and approximate time the buggy chunk is loaded?

CacPixel commented 1 year ago

debug.log Screenshot_2023-01-08_16-28-27 bug occurs at 16:28, player logged off at 16:30 line 23121 at debug.log

this rail is pretty long(like 120m) but as tested, a 60-meter-long rail can also cause that.

anatawa12 commented 1 year ago

Thank you for the log file.

If needed, I can provide the save folder and modelpack.

Can you give me the save folder and modelpack?

CacPixel commented 1 year ago

Thank you for the log file.

If needed, I can provide the save folder and modelpack.

Can you give me the save folder and modelpack?

I'll give you these files through discord. The save folder is a little big.

anatawa12 commented 1 year ago

Thank you for providing the test world. I tried reloading the the rail blocks many times with fixRTM env (dev environment) but I couldn't reproduce this problem. I'll try your all mods later.

CacPixel commented 1 year ago

I removed all other mods except ngtlib,rtm and fixrtm, but the bug also exists. The video has been uploaded to discord. I'll upload the video here (a backup)

https://user-images.githubusercontent.com/31470772/211574606-219410a0-dc5f-438a-97bc-55bc7b39d697.mp4

anatawa12 commented 1 year ago

I reproduced one time so I removed needs-triage but in my environment, this bug is very very rarely to happen.

CacPixel commented 1 year ago

I reproduced one time so I removed needs-triage but in my environment, this bug is very very rarely to happen.

Thanks a lot for testing the bug. It's pretty annoying that the bug interrupts the regular workflow of my modelpack which uses namy datamaps.

fixrtm / fixRTM