fixstars / ion-kit

Modernized graph-based data processing framework
MIT License
7 stars 6 forks source link

revert the order change for some devices #320

Closed Fixstars-momoko closed 1 month ago

Fixstars-momoko commented 1 month ago

The change of https://github.com/fixstars/ion-kit/pull/317 resolved some devices' issue, but caused another device's issue. We follow the policy of Aravis: "acquisition is not started automatically at stream creation, but should be done afterward" (https://github.com/AravisProject/aravis/blob/2ebaa8661761ea4bbc4df878aa67b4a9e1a9a3b9/docs/reference/aravis/porting-0.10.md) for the default devices.

basler device 1.0 device 1.2
aravis internal-0.8.30 + ion-kit 1.6.2 PASSED ERROR ERROR
aravis 0.8.31 + ion-kit BEFORE flip the order of ACQ and create stream PASSED PASSED ERROR
aravis 0.8.31 + ion-kit 3.1.0 AFTER flip the order of ACQ and create stream FAILED PASSED PASSED