Python bindings and samples using Pybind11

fixstars / libSGM

Stereo Semi Global Matching by cuda

Apache License 2.0

623 stars 189 forks source link

Python bindings and samples using Pybind11 #57

Closed slovak194 closed 4 months ago

slovak194 commented 4 years ago

Hi!

I made it possible to use your lib from python with a thin pybind11 wrapper. Please, let me know if such a contribution is welcome.

BR, Alex

atakagi-fixstars commented 4 years ago

Hi, @slovak194

Thank you for your contribution! I'll check.

atakagi-fixstars commented 4 years ago

Hi, @slovak194

Your contribution is welcome. I reviewed and left some comments on your changes.

Regards,

slovak194 commented 4 years ago

Great, @atakagi-fixstars! But where are your comments?

BR, Alex

atakagi-fixstars commented 4 years ago

@slovak194

Great, @atakagi-fixstars! But where are your comments?

Oh, sorry. My comment were not reflected.

I just posted it.

Regards,

slovak194 commented 4 years ago

Hi, @atakagi-fixstars!

I've changed PR according to your suggestions.

BR, Alex

atakagi-fixstars commented 4 years ago

Hi, @slovak194

Thanks for your changes!

Let me ask about how to install pysgm.

When I command pip3 install . after building project, pysgm is installed to /usr/local/lib/python3.7/site-packages/pysgm.

But shared library (pysgm.xxx.so) is not included. I need another procedure to make the path to shared library when I run samples.

Is there better way?

Regards,

slovak194 commented 4 years ago

Hi, @slovak194

Thanks for your changes!

Let me ask about how to install pysgm.

When I command pip3 install . after building project, pysgm is installed to /usr/local/lib/python3.7/site-packages/pysgm.

But shared library (pysgm.xxx.so) is not included. I need another procedure to make the path to shared library when I run samples.

Is there better way?

Regards,

That's a good point, let me investigate how to do that properly. I'll come up with proposal soon.