search

fixt / react-native-page-swiper

91 stars 47 forks source link

Actually hide other views #7

Closed esamattis closed 8 years ago

esamattis commented 8 years ago

When using react-native-side-menu1 previous slide was pulled to view instead of the menu.

Mokto commented 8 years ago

Thank you, it is really nice !

But it seems that it does not work on ios. ;)

esamattis commented 8 years ago

Weird. I'm using this only on iOS.

Mokto commented 8 years ago

Ok it's working, sorry.

@cgarvis if you can't update your plugin, at least make @epeli or someone else collaborator so that we can move on ! Need this PR to be put in this great plugin.

Thanks in advance.

esamattis commented 8 years ago

I would be comfortable to merge my PR:s. We're already running them in production. I have also a fix for #2 but I haven't bothered sending it because the previous ones are still pending...

EDIT: I sent it too now https://github.com/fixt/react-native-page-swiper/pull/14