fixthestatusquo / archive-proca-backend

Backend for the ultimate petition/campaigning tool
GNU Affero General Public License v3.0
7 stars 2 forks source link

Data deletion requirements #85

Open marcinkoziej opened 3 years ago

marcinkoziej commented 3 years ago

Creating this issue to figure out how to delete data in Proca backend. The entity structure that it's most perplexing is this hierarchy:

Campaign <---- Action Page <---- Supporter <--- Action
    ^    <-----------^-------------'             ,'
    `---------------- `-------------------------'

There is this hierarchy and then also actions and supporters have links to upper "parents" in hierarchy. Question: What to do with DELETEing Campaigns, or Action Pages that have Actions/Supporters. We do not want to delete action data/personal data in such cases, so options we have are:

  1. Option: no deleting allowed

    • campaign or action page with supporters is not deletable
  2. Option: delete campaign, leave "orphan" action page

    • might be useful to have an action page, to know what kind of journey produced the actions
    • but such action page might be an annoyance when managing orgs other action pages. For instance, it's name will ba still taken; Where should it be displayed in the UI? In some sort of action page trash bin?
  3. Option: delete campaign and action page, leave orphan action/supporter data

    • the member data is still there, so can be recovered
    • but it cannot be attributed back to the campaign, which might or might not be problem (it was removed after all)
    • leaves no mess in the campaign/action page records that are used
tttp commented 3 years ago

I'd add a boolean "deleted" and not delete them or export them by default, but keep the data there, but changing the path to "deleted"+existing path so we don't "block" the path anymore

marcinkoziej commented 3 years ago

You talk about keeping campaign and action page or just action page

tttp commented 3 years ago

I was talking about action pages. For campaigns, I don't have strong opinion, recreating them should be fairly trivia if/when needed if we still have the action pages

But might be good for consistency to havethe deleted flag on the campaign and actionpage?