fixthestatusquo / proca-server

Proca server, SDKs and services
https://proca.app
5 stars 3 forks source link

reply-to configurable #247

Closed tttp closed 5 months ago

tttp commented 5 months ago

Hi @destag,

for most campaign/organisations, if a target replies to the email, it should go to the initial sender.

however, it should be an option to disable that (for instance if some targets starts abusing the reply to)

Right now, it's hardcoded to remove the reply to,

https://github.com/fixthestatusquo/proca-server/commit/f66cc7b6457fe7ff0e9d35420930e1e5d3564bea

I'm not sure what's the best way to configure that, it can be either at the campaign or organisation level.

X+

tttp commented 5 months ago

Note: it is a change on the database and server, there is no interface yet to toggle that behaviour, just go in the database

if we need to offer it on a regular basis, we would need to expose it into the graphql AND modify the cli to change it

destag commented 5 months ago

@tttp I added reply_enabled also to graphql Org schema, so it is possible to change this flag through api. Should I remove this and leave the possibility of modification only through the database?

tttp commented 5 months ago

aah, sorry I missed it. no it's fine

On Sat, Jun 8, 2024 at 11:02 PM Przemysław Pietras @.***> wrote:

@tttp https://github.com/tttp I added reply_enabled also to graphql Org schema, so it is possible to change this flag through api. Should I remove this and leave the possibility of modification only through the database?

— Reply to this email directly, view it on GitHub https://github.com/fixthestatusquo/proca-server/issues/247#issuecomment-2156182428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7LKX7HKZN2FBKCONI52LZGNWOFAVCNFSM6AAAAABIYJ4FN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGE4DENBSHA . You are receiving this because you were mentioned.Message ID: @.***>