fizechef / Unique-Dungeons-Release

Other
0 stars 0 forks source link

crash when trading with adventurer villager #3

Open abielaird opened 1 month ago

abielaird commented 1 month ago

when i trade with the adventurer villager the game freezes and i have to force shut down my computer to exit. first time i traded was fine, i got the first notebook, next i tried to buy a map and the second notebook and it freezes. i can move around but i cant break, pick up blocks and no mobs move. latest.log

fizechef commented 1 month ago

First of all a usefull tip for Windows, if a fullscreen program crashes and you can't tab out to use task manager to close it, you can use CTRL ALT DEL to log out and back in to your Windows profile and then use task manager so you don't have to force shutdown you whole PC.

The issue here seems that the ModernFix mod kills the local game Server thread after a single tick took 40s to execute without response. Its not a hard crash but a timeout triggered because loading the treassure map takes to long.

[17:08:42] [ModernFix integrated server watchdog/ERROR]: A single server tick has taken 40001, more than 40000 milliseconds

The Minecraft treassure maps work by first locating a suitable generation location for the structure and then generate the structure there. We have accidentally made an error with blockstates in the structure files, and then left this error in intentionally as it triggers exactly after the locating is done at the beginning of the actual generation. This shows how much time is spend on locating and how much on generating.

[17:08:25] [Worker-Main-5/WARN]: Unable to read property: facing with value: up for blockstate: {Name:"uniquedungeons:city_center_lectern",Properties:{facing:"up",open:"false"}}

It seems like in your case the location takes 23s, wich is insanely long and the actual generation of the Snowy City takes longer then 17s wich is indeed unusually long as well. As the Snowy City is only generating in vanilla snowy peaks and takes the topology of the terrain into account when placing the individual buildings, it is pretty rare and takes long to generate, but this is highly ampliefied if you are using a lot of biome and generation mods. Mods that change the snowy peaks biome are especially bad here.

We are aware and working on this and made big improvements to the generation time in the update 0.70.3, so if you are using older versions you may want to update. The main issue is that we can't do anything about the 23s location time as this is a vanilla feature we don't want to touch for compatability reasons. We will also add some config possibilities to add more biomes to the whitelist to reduce location times in high biome count modpacks.

You can also try to use the /locate command to prelocate a Snowy City, but this will very likely result in the same issue as the command and the map do basically the same thing but it may trigger the timeout in a different way, so its worth a try. As long as we havn't released any new version, the only way to "fix" this is to increase the timeout window of ModernFix.

fizechef commented 1 month ago

Also it would be very helpful if you could provide us with a biome and terrain mod list, so we can maybe implement specific cases for some of them.

And thanks for posting this issue in general, these reports are always ver useful.

abielaird commented 1 month ago

Thank you, do you know how i can increase the time out window of modern fix? The terrain mods i use are: Terrablender Terralith Biomes o plenty Lets do meadow Lets do beach party

I believe thats it

I did use the locate command and it worked fine.

So are you saying its just slow and if i wait long enough it'll be fine?

On Sun, Aug 18, 2024, 8:58 PM fizechef @.***> wrote:

Also it would be very helpful if you could provide us with a biome and terrain mod list, so we can maybe implement specific cases for some of them.

And thanks for posting this issue in general, these reports are always ver useful.

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2295526542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM2CF4UT5QEHS5XR2LLZSFGMJAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGUZDMNJUGI . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

Thanks for the mod list.

I have never configured ModernFix myself, so I don't know if its even possible to increase the timeout window. If its doable it should be in the mods config file somewhere.

And yes, if the locate command works, it works with the maps as well, they basically do the same thing. Its just a very big lag until a location is found and the structure is generated there. After using locate the map should also load instantly without lags, as the command did all the work already.

abielaird commented 1 month ago

Okay, i wasn't able to actually use the map yet. It would fo that heavy lag after i bought the map, i haven't had a chance to use it. Is this due to the same thing?

On Mon, Aug 19, 2024, 4:02 PM fizechef @.***> wrote:

Thanks for the mod list.

I have never configured ModernFix myself, so I don't know if its even possible to increase the timeout window. If its doable it should be in the mods config file somewhere.

And yes, if the locate command works, it works with the maps as well, they basically do the same thing. Its just a very big lag until a location is found and the structure is generated there.

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2297450945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM2U3GCC5YXO3RFWEVTZSJMQDAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGQ2TAOJUGU . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

This might be a different unrelated issue.

So you can locate and tp to a Snowy City in a world and still not use the treassur map? Can you post a log of this lag?

abielaird commented 1 month ago

Not the snowy city, but the desert ruins. I tried to buy a desert ruin map and a notebook, it froze, then i used locate command to find one, traveled there with a friend and it was there, looked fine. This was like a week ago and I've been playing every day since so I'm not sure i could find the log

On Mon, Aug 19, 2024, 11:56 PM fizechef @.***> wrote:

This might be a different unrelated issue.

So you can locate and tp to a Snowy City in a world and still not use the treassur map? Can you post a log of this lag?

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2297965876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM3G3Q2VW2NPNSEIM63ZSLEBHAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXHE3DKOBXGY . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

Thats even more interesting as we have never seens any issue with the desert ruin at all.

If you can find the log this would be amazing, but if not just remember to send it in if this ever happens again.

abielaird commented 1 month ago

Is there a way i can recreate this and show you the most recent log?

On Wed, Aug 21, 2024, 1:03 AM Abigail Laird @.***> wrote:

Not the snowy city, but the desert ruins. I tried to buy a desert ruin map and a notebook, it froze, then i used locate command to find one, traveled there with a friend and it was there, looked fine. This was like a week ago and I've been playing every day since so I'm not sure i could find the log

On Mon, Aug 19, 2024, 11:56 PM fizechef @.***> wrote:

This might be a different unrelated issue.

So you can locate and tp to a Snowy City in a world and still not use the treassur map? Can you post a log of this lag?

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2297965876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM3G3Q2VW2NPNSEIM63ZSLEBHAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXHE3DKOBXGY . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

I don't know. I have no clue what the issue might be.

As I said, the desert dungeon is almost 1.5 years old now, nothing changed since then and we didn't have a single issue with its generation at any point.

abielaird commented 1 month ago

Hey! I did some more experimenting. I bought JUST the notebook, everything was fine, then i bought the map, then it froze, but after waiting a few minutes tge lag went a way and everything was back to normal, i used the map, it worked just fine, showed me to the same place i located. So now i would say the only real problem is the massive lag which im not sure how to fix.

On Wed, Aug 21, 2024, 1:07 AM Abigail Laird @.***> wrote:

Is there a way i can recreate this and show you the most recent log?

On Wed, Aug 21, 2024, 1:03 AM Abigail Laird @.***> wrote:

Not the snowy city, but the desert ruins. I tried to buy a desert ruin map and a notebook, it froze, then i used locate command to find one, traveled there with a friend and it was there, looked fine. This was like a week ago and I've been playing every day since so I'm not sure i could find the log

On Mon, Aug 19, 2024, 11:56 PM fizechef @.***> wrote:

This might be a different unrelated issue.

So you can locate and tp to a Snowy City in a world and still not use the treassur map? Can you post a log of this lag?

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2297965876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM3G3Q2VW2NPNSEIM63ZSLEBHAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXHE3DKOBXGY . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

îf you locate the structure before you buy the map, do you get the same lag either during locating or when opening the map?

fizechef commented 1 month ago

and how far away was the dungeon when you located it?

abielaird commented 1 month ago

I am at around 200, -1500 and the dungeon was i think 3000, -3000 so just a couple k away.

Also i wanted to ask, do you have a guide for your mod? Im note sure how to use the ancient note fragments and make things like the amethyst sheild. Im also not sure how the pedestals work or what to use the guardian sword and that diamond axe in the dungeon for. If im supposed to figure it out myself thats totally fine! But the crafting and pedestal are hard to find info on.

On Wed, Aug 21, 2024, 1:32 AM fizechef @.***> wrote:

and how far away was the dungeon when you located it?

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2301239502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELMYNM6LLI7MYROTQFZDZSQYAPAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGIZTSNJQGI . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

There is no guide I know of, at least we didn't make one. We want everything to be explorable and logical just using in game hints so we don't see the benefit of an external guide.

First of all, the axe and the guardian sword are just random mid tier loot items, they have no further use or anything.

You can't "craft" the actual artifact items. Both dungeons have a way of aquiring them, there is at least one hidden in every desert dungeon, most of the time around 2 or 3. If you haven't found one you may have missed a hidden passage or something like that. You will clearly notice them if you find them, they all have unique textures, models and descriptions. The Snowy City works a little different, there is a hidden mechanic that lets you convert notes into the corresponding item there. If you want more hints just let me know.

There are two different pedestals. The one with red carpet that spawns in villages for example has no "use" other then displaying items and it is the workstation that converts a villagers to the adventurer. The one with yellow carpet is basically a lock that opens when you put the right item in the top slot.

The crafting recipies will be added to the vanilla crafting book thing next update, its already done, we just want to finish some other things to put actual content in as well.

abielaird commented 1 month ago

Awesome, thank you for the hints. I think i possibly might have blown up the artifacts then lol. I was trying to dismantle a trap but set it off and it blew up a huge area. However we plan on going back there and making it into a secret base because it has spawned in the top of a lush cave, lots of areas in the dungeon have some beautiful balcony views. Thank you so much for your help and answering my questions. This mod is by far the best dungeon mod I've seen, i wish there were more like it. I enjoy the ones with lots of monsters, but disarming booby traps and puzzles is much more fun.

On Wed, Aug 21, 2024, 2:13 AM fizechef @.***> wrote:

There is no guide I know of, at least we didn't make one. We want everything to be explorable and logical just using in game hints so we don't see the benefit of an external guide.

First of all, the axe and the guardian sword are just random mid tier loot items, they have no further use or anything.

You can't "craft" the actual artifact items. Both dungeons have a way of aquiring them, there is at least one hidden in every desert dungeon, most of the time around 2 or 3. If you haven't found one you may have missed a hidden passage or something like that. You will clearly notice them if you find them, they all have unique textures, models and descriptions. The Snowy City works a little different, there is a hidden mechanic that lets you convert notes into the corresponding item there. If you want more hints just let me know.

There are two different pedestals. The one with red carpet that spawns in villages for example has no "use" other then displaying items and it is the workstation that converts a villages to the adventurer. The one with yellow carpet is basically a lock that opens when you put the right item in the top slot.

The crafting recipies will be added to the vanilla crafting book thing next update, its already done, we just want to finish some other things to put actual content in as well.

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2301305203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM7MXSAW3JGQZSKMNP3ZSQ42DAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGMYDKMRQGM . You are receiving this because you authored the thread.Message ID: @.***>

fizechef commented 1 month ago

Yeah you probaly blew up the artifact room xD

And thanks for the compliments.

Also we want to try to make a completely unique mechanic or style for every dungeon, and as you haven't used the main feature of the Snowy City yet, I'd really like to hear how you like it. Just don't expect to build a nice base there afterwards, just a small warning.

abielaird commented 4 weeks ago

Okay lol

On Wed, Aug 21, 2024, 2:28 AM fizechef @.***> wrote:

Yeah you probaly blew up the artifact room xD

And thanks for the compliments.

Also we want to try to make a completely unique mechanic or style for every dungeon, and as you haven't used the main feature of the Snowy City yet, I'd really like to hear how you like it. Just don't expect to build a nice base there afterwards, just a small warning.

— Reply to this email directly, view it on GitHub https://github.com/fizechef/Unique-Dungeons-Release/issues/3#issuecomment-2301334532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTELM7GBPZ6JS6QVXIHXNLZSQ6TTAVCNFSM6AAAAABMWXFKXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRGMZTINJTGI . You are receiving this because you authored the thread.Message ID: @.***>