search

fizruk / http-api-data

Converting to/from HTTP API data like URL pieces, headers and query parameters.
http://hackage.haskell.org/package/http-api-data
Other
52 stars 42 forks source link

Allow cookie-0.5 #137

Closed spencerjanssen closed 5 months ago

phadej commented 5 months ago

The changelog for cookie-0.5 says

This is a breaking change, as it changes the behavior of parseCookies and parseSetCookie to no longer include the surrounding double quotes in the cookie value. This is the correct behavior according to the RFC.

And we do use parseSetCookie. Have you verified that things still work?

spencerjanssen commented 5 months ago

I did run the test suite, yes. Reasonable uses of the API provided by cookie or http-api-data will not break. According to the RFC user agents may optionally wrap the cookie value in double quotes.

I think we are also covered by the disclaimer attached to the instances for SetCookie:

/Note:/ this instance works correctly for alphanumeric name and value

I can add a note about this in the changelog if you'd like.

phadej commented 5 months ago

Yes, I think it's better to do a separate release for this, i.e. not just a "silent" Hackage revision.

spencerjanssen commented 5 months ago

Sounds good. I can add a changelog entry. Shall I include a minor version bump up to 0.6.1 as well?

phadej commented 5 months ago

Shall I include a minor version bump up to 0.6.1 as well?

Please do.

spencerjanssen commented 5 months ago

Done, thanks for the review!