fizx / robots

robots.txt parser
40 stars 17 forks source link

Please don't use open-uri #8

Open postmodern opened 8 years ago

postmodern commented 8 years ago

I noticed you request /robots.txt using open-uri. Since open-uri overrides Kernel#open, it also allows for possible command injection (ex: open("| ls")). I think using Net::HTTP.get would be Good Enough (tm).