Partially migration from keras to tf.keras

fizyr / keras-retinanet

Keras implementation of RetinaNet object detection.

Apache License 2.0

4.38k stars 1.96k forks source link

Partially migration from keras to tf.keras #1445

Closed ha-nso-li closed 4 years ago

ha-nso-li commented 4 years ago

PR #1422 provides keras 2.4 compatibility. Keras 2.4 just redirecting API to tf.keras.

So we could migration into tf.keras by just replace keras with tf.keras.

This PR is not a replacement of tf-retinanet. Keras dependency still exists because keras-resnet requires keras.
Minimum tensorflow version is changed to 2.3.0. (2.2.0 occurs an error in issue #1444)
From keras 2.4.0, I couldn't access mobilenet.BASE_WEIGHT_PATH so I hard-coded it.

hgaiser commented 4 years ago

Looks good, I think we should merge this PR. I'm not so sure if this works though. As you said, keras-resnet requires keras. In my previous experience, mixing tf.keras and keras does not work out well. Did this change in keras 2.4 since it is just forwarding the API?

ha-nso-li commented 4 years ago

When I tested with latest version it works. At least everything works fine since Keras 2.4 and Tensorflow 2.3. I don't know about previous versions well; but I think so like you said. It must works even if mixed because both are the same API.

hgaiser commented 4 years ago

Just tried it out and everything seems to work as expected, thanks!