search

fizyr / subst

Apache License 2.0
12 stars 5 forks source link

Support `&dyn VariableMap` #5

Closed andylizi closed 1 year ago

andylizi commented 1 year ago

This should be a backward-compatible change.

de-vri-es commented 1 year ago

Thanks for the PR. Changes look good!

I think it would be good to add some tests that use a &dyn VariableMap to ensure it doesn't break in the future.

Do you want to do that or shall I?

de-vri-es commented 1 year ago

I want to release it, so I added a test :)

de-vri-es commented 1 year ago

Released as 0.2.3 :tada:

Thanks again!

andylizi commented 1 year ago

Thank you for the great work! 🎉