search

fizzed / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
290 stars 130 forks source link

Netty4 merged with master (plus updates) #6

Closed JChrist closed 8 years ago

JChrist commented 8 years ago

I have merged all latest changes within master to netty4 (including AlertNotification and ReplaceSm) I updated pom to match master (apart from netty 4 dependency) I updated netty 4 to latest release 4.0.35.Final Do you think this can come out as a new release in the 6.0.0-netty4 series?

jjlauer commented 8 years ago

Wow, nice merge! That must have been a ton of work :-)

As a side note, I wish we had forgone a netty4 branch and actually did sub-modules that implemented bindings to netty3, netty4, and even my preferred nio library these days to xnio. Originally, we thought we could make the jump to netty4 and nix netty3, but folks still use the two different versions.

I'm happy to take a look at this and do a release for you. Stay tuned.

JChrist commented 8 years ago

Thanks! I would be more than happy to assist with that, so if you have any kind of roadmap or list of tasks that I can go through, please share.

jjlauer commented 8 years ago

Pushed your changes out to maven central and updated some of the README.md

jjlauer commented 8 years ago

@JChrist I wrote up a summary of the netty3/netty4 idea. https://github.com/fizzed/cloudhopper-smpp/issues/7