search

fizzed / font-mfizz

Font Mfizz - Vector Icons for Technology and Software Geeks
537 stars 111 forks source link

Java icon (and potentially others) not horizontally centering properly. #48

Open KennyWibowo opened 7 years ago

KennyWibowo commented 7 years ago

Using text-align: center really brings this out.

image

image

KennyWibowo commented 7 years ago

Could potentially add to the CSS properties to fit the box around the icon exactly, though not sure, not much of a CSS wizard.

tiaaaa123 commented 7 years ago

I'm having the same issue right now. With multiple icon.

xied75 commented 6 years ago

This really is an issue, if I drag and drop "java-bold" svg file onto http://fontello.com/, this java icon will push all my other well-behaved icons up and being clipped. Anyone knows how to fix this?

jjlauer commented 6 years ago

@xied75 If I had to guess its probably something with the svg bounding box. If you open up the svg in an editor that's something that can be tweaked. When I add icons I was careful about tweaking/simplifying the svgs to be "renderable" to a font. Not every svg can easily be converted so you need to do a number of things.

Now, that being said, in the many years after this font's release, I bet there are better tools we could compile the font with compared to when it was originally developed. I haven't had time recently to try and give some of the new tools a shot, but maybe I can try to find some time in the next couple months. If anyone in the community could give it a try, any PRs would be awesome!

Alhadis commented 6 years ago

If I had to guess its probably something with the svg bounding box

Yep, it is. Actually, most of the icons are misaligned or sized incorrectly, which is what led to me fixing them all by hand. Didn't consider a PR because the adjustments would've been a breaking change for some layouts, I imagine.

So yeah, easy fix for now is to use this SVG for the java-bold icon. =)

jjlauer commented 6 years ago

@Alhadis Yeah, I can sympathize with the hand work. It was a lot of work to put together what's in this repo too. I actually do think those as a PR would have been awesome, but I get why you had concerns about breaking compat. I read your docs on optimizing geometry and I'm wondering what editor/tool you ended up using?

Alhadis commented 6 years ago

Just Adobe Illustrator, and having an attention to detail. That's seriously all. =)

Alhadis commented 6 years ago

I have a background in graphic design, so I may as well put it to use. 😀

jjlauer commented 6 years ago

@Alhadis I've got almost zero graphic design experience -- so its cool to see how you did it :-) I tried using only open source tools, but I'm guessing Adobe is the only way to really go in the end. I'll dig into what you did further to see how we can polish things up.

Alhadis commented 6 years ago

Hahah! Nooo, the choice of program has nothing to do with it... I've been using Adobe software for over 10 years, so everything's burned deeply into muscle memory. What I did could've easily been done by somebody with an equal level of skill in Inkscape. =)