search

fizzed / play-twitter

PlayFramework 2.x module to fetch, cache, and display tweets from Twitter
http://fizzed.com/oss/play-module-twitter
10 stars 10 forks source link

Support Play Framework 2.4.X #6

Open haroldoramirez opened 7 years ago

haroldoramirez commented 7 years ago

Hello,

This plugin is very interesting, but I'm using playframework 2.4.11 and this is incompatible. Is there a forecast for this plugin? Or another alternative?

Thank you very much

jjlauer commented 7 years ago

Hi Haroldo,

One of my issues with the play framework after awhile is the incompatibility of plugins between versions (2.1, 2.2, etc.). Its tough to have to recompile and deploy a plugin just to hit a new version.

If you like the plugin, I'd suggest you fork it, get it to compile for Play 2.4, and consider releasing it. I'm happy to point my README to your fork for folks who are looking for future support.

-Joe

On Mon, May 8, 2017 at 9:21 AM, Haroldo Ramirez notifications@github.com wrote:

Hello,

This plugin is very interesting, but I'm using playframework 2.4.11 and this is incompatible. Is there a forecast for this plugin? Or another alternative?

Thank you very much

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fizzed/play-twitter/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjwAnipG-3hHM2BQhp729oFGiDULPplks5r3xbOgaJpZM4NT8FC .

haroldoramirez commented 7 years ago

Hello jjlauer,

I will try something, I do not know where to start but I will download the plugin and do tests.

Thank you

haroldoramirez commented 6 years ago

Hello Joe,

Thanks for the opportunity

I've been busy on other projects and managed to separate time to dedicate myself to updating the twitter plugin. The first time I work with plugins.

I created a play project in version 2.4.11 and adapted the fizzed-twitter code for the version of play 2.4.11.

The code has been compiled successfully.

My situation is that version 2.4 of play added the dependency injection and this caused the play.Plugin to be deprecated being totally removed in version 2.5. The workaround is to use the play.api.inject.Module.

It is very interesting work with plugins but I have little knowledge until the moment to get a solution.

Can you give me a light?

Just below you can take a look at the code

https://github.com/haroldoramirez/play-twitter-2.4.X

Thank you so much