search

fizzwidget / faction-friend

WoW addon for reputation tracking
10 stars 5 forks source link

LUA Error v.8.0.1 (PetActionBarFrame:SetPoint()) #51

Open Yinepuhotep opened 6 years ago

Yinepuhotep commented 6 years ago

Date: 2018-08-22 17:22:16 ID: 28 Error occured in: AddOn: GFW_FactionFriend Count: 317 Message: Note: AddOn GFW_FactionFriend attempted to call a protected function (PetActionBarFrame:SetPoint()) during combat lockdown. Debug:

..\FrameXML\UIParent.lua:3006: UIParentManageFramePositions() ..\FrameXML\UIParent.lua:2326: ..\FrameXML\UIParent.lua:2313

..\FrameXML\UIParent.lua:3115: ..\FrameXML\UIParent.lua:3113

..\FrameXML\MainMenuBar.lua:60: SetPositionForStatusBars() ..\FrameXML\MainMenuBar.lua:8: OnStatusBarsUpdated() ..\FrameXML\StatusTrackingManager.lua:179: LayoutBars() ..\FrameXML\StatusTrackingManager.lua:84: UpdateBarsShown()

  [string "*:OnEvent"]:1

Locals: None AddOns: Swatter, v7.7.6000 (SwimmingSeadragon) WowheadLooter, v80000 Ace3, v Altoholic, vr189 ArtifactButton, v6.0 Atlas, vv1.44.03 AtlasArena, vv1.07.02 AtlasBattlegrounds, vv1.44.00 AtlasBurningCrusade, vv1.44.00 AtlasCataclysm, vv1.44.00 AtlasClassicWoW, vv1.44.00 AtlasClassOrderHalls, vv1.44.00 AtlasDungeonLocs, vv1.44.00 AtlasLegion, vv1.44.00 AtlasMistsofPandaria, vv1.44.00 AtlasOutdoorRaids, vv1.44.00 AtlasScenarios, vv1.44.00 AtlasTransportation, vv1.44.00 AtlasWarlordsofDraenor, vv1.44.00 AtlasWorldEvents, vv3.24 AtlasWrathoftheLichKing, vv1.44.00 AtlasMajorCitiesEnhanced, vv1.16 AucAdvanced, v7.7.6000 (SwimmingSeadragon) AucFilterBasic, v7.7.6000 (SwimmingSeadragon) AucScanData, v7.7.6000 (SwimmingSeadragon) AucStatHistogram, v7.7.6000 (SwimmingSeadragon) AucStatiLevel, v7.7.6000 (SwimmingSeadragon) AucStatPurchased, v7.7.6000 (SwimmingSeadragon) AucStatSimple, v7.7.6000 (SwimmingSeadragon) AucStatStdDev, v7.7.6000 (SwimmingSeadragon) AucUtilFixAH, v7.7.6000 (SwimmingSeadragon) BadBoy, vv8.0.7 BadBoyGuilded, vv8.0.0 BadBoyIgnore, vv8.0.0 BadPet, vv1.0.12 BagBrother, v Bagnon, v8.0.2 Bartender4, v4.8.1 BeanCounter, v7.7.6000 (SwimmingSeadragon) BugSack, vv8.0.2 CanIMogIt, v8.0.0v1.11 DataStore, vr65 DataStoreAchievements, vr47 DataStoreAgenda, vr29 DataStoreAuctions, vr50 DataStoreCharacters, vr42 DataStoreContainers, vr59 DataStoreCrafts, vr82 DataStoreCurrencies, vr37 DataStoreGarrisons, vr24 DataStoreInventory, vr53 DataStoreMails, vr52 DataStorePets, vr44 DataStoreQuests, vr45 DataStoreReputations, vr43 DataStoreSpells, vr32 DataStoreStats, vr31 DataStoreTalents, vr61 DBMCore, v8.0.4 DBMDefaultSkin, v DBMLDB, v DBMSpellTimers, v DBMStatusBarTimers, v Decliner, v8.0.1.180722.1 Decursive, v2.7.6.1 Enchantrix, v7.7.6000 (SwimmingSeadragon) EnchantrixBarker, v7.7.6000 (SwimmingSeadragon) FBOutfitDisplayFrame, v1.9.1 FBTitan, v1.0.15 FBTrackingFrame, v1.9 FishingBuddy, v1.9.13 FlightMapEnhanced, v3.0.14 GarrisonCommanderBroker, v2.19.0 1.1.0 GatherMate2, v1.43 GatherMateSharing, vv1.11 GFWDiggerAid, v8.0 GFWFactionFriend, v8.0.1 GFWFeedOMatic, v8.0 GFWHoverTips, v8.0 GFWScrollMaker, v8.0 GFWXPVisualizer, v8.0 GFWZippyLighter, v8.0 gmFonts, v801-2018071801 GTFO, v4.46.2 HandyNotes, vv1.5.3 HandyNotesBrokenShore, vv1.29 HandyNotesDraenorTreasures, v1.21 HandyNotesFieldPhotographer, v8.0.0.0 HandyNotesHigherLearning, v8.0.0.0 HandyNotesLegionClassOrderHalls, vv1.29 HandyNotesLegionRaresTreasures, v1.1 HandyNotesWellRead, v8.0.0.0 Healium, v iFriends, v8.0.4 iGuild, v8.0.4 iLib, v1.0 Informant, v7.7.6000 (SwimmingSeadragon) iSocial, v8.0.3 KuiMedia, v KuiNameplates, v KuiNameplatesCore, v KuiNameplatesElite, vv2.4 LightHeaded, vv80000-1.1.0-431924f MacroToolkit, vv7.3.0.2 MacroToolkitMacroBox, vv7.2.0.0 MacroToolkitIcons, v7.2.0.0 MailCommander, v0.9.8 80000 MasterPlanA, vA MicroDeclineDuel, vv8.0 MogIt, v3.8.10 MogItArtifact, v3.8.10 MogItCloth, v3.8.10 MogItLeather, v3.8.10 MogItMail, v3.8.10 MogItOneHanded, v3.8.10 MogItOther, v3.8.10 MogItPlate, v3.8.10 MogItRanged, v3.8.10 MogItTwoHanded, v3.8.10 NOP, v09.10 14.08.2018 NPCScan, v8.0.1.8 Omen, v3.2.0 Outfitter, v5.20.3 Overachiever, v1.0.3 OverachieverCache, v1.0.3 OverachieverTrade, v1.0.3 Pawn, v2.2.27 Prat30, vr1178
Prat30Libraries, v RETabBinder, v1.4.0 sct, v8.1 sctd, v7.1 SharedMedia, v8.0.2 SharedMediaClassicalFonts, v7.3-release1 SharedMediaAdditionalFonts, v1.0.26 SilverDragon, vv4.0.13 SilverDragonBattleForAzeroth, vv4.0.13 SilverDragonBurningCrusade, vv4.0.13 SilverDragonCataclysm, vv4.0.13 SilverDragonLegion, vv4.0.13 SilverDragonMists, vv4.0.13 SilverDragonVanilla, vv4.0.13 SilverDragonWarlords, vv4.0.13 SilverDragonWrath, vv4.0.13 Skillet, v4.04 SlideBar, v7.7.6000 (SwimmingSeadragon) SpartanUI, v4.6.9 SpartanUIArtwork, v4.6.9 SpartanUIFilmEffects, v4.6.9 SpartanUIPartyFrames, v4.6.9 SpartanUIPlayerFrames, v4.6.9 SpartanUIRaidFrames, v4.6.9 SpartanUISpinCam, v4.6.9 SpartanUIStyleFel, v4.6.9 SpartanUIStyleMinimal, v4.6.9 SpartanUIStyleTransparent, v4.6.9 SpartanUIStyleWar, v4.6.9 Stubby, v7.7.6000 (SwimmingSeadragon) TabardMaster, v125 TipTac, v18.08.20 TipTacItemRef, v18.08.12 TipTacTalents, v18.07.30 Titan, v5.14.4.80000 TitanBag, v5.14.4.80000 TitanClan, v39 TitanClock, v5.14.4.80000 TitanGold, v5.14.4.80000 TitanLocation, v5.14.4.80000 TitanLootType, v5.14.4.80000 TitanPerformance, v5.14.4.80000 TitanRepair, v5.14.4.80000 TitanRestPlus, v8.0.0.0 TitanSocial, v8.0.1 TitanVolume, v5.14.4.80000 TitanXP, v5.14.4.80000 TomTom, vv80001-1.0.2 TomTomPing, v1.3 r038 totalRP3, v1.4.4 totalRP3Data, v totalRP3Extended, v1.2.0 totalRP3ExtendedImpExport, v1.2.0 totalRP3ExtendedTools, v1.2.0 totalRP3KuiNameplates, v1.4.0 TradeSkillMaster, vv4.1.1 TradeSkillMasterAppHelper, vv4.0 TRP3CurrentlyFrame, v1.6 WorldQuestTracker, v BlizRuntimeLib_enUS v8.0.1.80000 (ck=1443)

Yinepuhotep commented 6 years ago

Note: This error, and all the ones following, occurred when my hunter was taming a new pet.

fizzwidget commented 6 years ago

Thanks — these are all the same underlying issue, so I'll be collapsing the bug reports.

Yinepuhotep commented 6 years ago

Makes sense. When we get a batch of messages like this in Swatter or Bugsack, would you rather we put them all in a single thread, or report them individually so you can decide if they're all part of a single issue?

fizzwidget commented 6 years ago

Separate reports is fine, particularly if they seem to be triggered by different things happening in your game.

Speaking of which, I'm having a devil of a time reproducing this myself — here I thought your issue of taming pets would be key. All the reports I'm getting have a large number of other addons installed. While there's a good chance the problem is still FactionFriend's fault, it'd help to know when I've fixed it. If you get a chance to try with some of your addons disabled until you find a combination that causes / doesn't cause the error, that'd help a lot.

Addonman commented 5 years ago

Message: Note: AddOn GFW_FactionFriend attempted to call a protected function (MainMenuBar:SetPoint()) during combat lockdown. Debug:

..\FrameXML\UIParent.lua:2946: UIParentManageFramePositions() ..\FrameXML\UIParent.lua:2329: ..\FrameXML\UIParent.lua:2316

..\FrameXML\UIParent.lua:3118: ..\FrameXML\UIParent.lua:3116

...ard_UIWidgets\Blizzard_UIWidgetBelowMinimapFrame.lua:25: layoutFunc() ...dOns\Blizzard_UIWidgets\Blizzard_UIWidgetManager.lua:225: UpdateWidgetSetContainerLayout() ...dOns\Blizzard_UIWidgets\Blizzard_UIWidgetManager.lua:318: ProcessWidgetSet() ...dOns\Blizzard_UIWidgets\Blizzard_UIWidgetManager.lua:340: UpdateAllWidgets() ...dOns\Blizzard_UIWidgets\Blizzard_UIWidgetManager.lua:33: ...dOns\Blizzard_UIWidgets\Blizzard_UIWidgetManager.lua:31

I dont think its pet only related.I play on all diff chars with pets or without pets and messages like this most common error i get in game in BFa . Similar to this addon other addon that does similar to this-calling protected function during combat is Neuron. I always thought it has something to do with creating macro buttons during combat of sorts (in case or Neuron) and that this is more of Blizz fault then autors of addon.I could be wrong.

ShaunaGordon commented 5 years ago

I think I've got some more information on replicating this. I've been able to do so pretty consistently any time I've been in combat, or very shortly after falling out of combat, in which I've gained reputation (ie - completing a world quest where the act of killing things achieves the goal).

From what I've observed, it switches the faction, complete with distinct colors and progression highlighting, but the act of displaying in the Faction: Standing Progress/Total format fails, falling back to the default display format. If you have that format, mousing over the bar shortly after the standing-change combat throws the error and reverts to the default display format.

Swatter logs:

Date: 2019-06-12 18:00:08
ID: -1
Error occured in: AddOn: GFW_FactionFriend
Count: 4
Message: Note: AddOn GFW_FactionFriend attempted to call a protected function (MainMenuBar:ClearAllPoints()) during combat lockdown.
Debug:
   [C]: ClearAllPoints()
   ..\FrameXML\MainMenuBar.lua:43: SetPositionForStatusBars()
   ..\FrameXML\MainMenuBar.lua:8: OnStatusBarsUpdated()
   ..\FrameXML\StatusTrackingManager.lua:181: LayoutBars()
   ..\FrameXML\StatusTrackingManager.lua:84: UpdateBarsShown()
   ..\FrameXML\StatusTrackingManager.lua:208:
      ..\FrameXML\StatusTrackingManager.lua:204
Locals:
None
AddOns:
  Swatter, v8.1.6241 (SwimmingSeadragon)
  AdvancedInterfaceOptions, v1.2.11
  AucAdvanced, v8.1.6201 (SwimmingSeadragon)
  AucFilterBasic, v8.1.6228 (SwimmingSeadragon)
  AucStatHistogram, v8.1.6230 (SwimmingSeadragon)
  AucStatiLevel, v8.1.6234 (SwimmingSeadragon)
  AucStatPurchased, v8.1.6231 (SwimmingSeadragon)
  AucStatSimple, v8.1.6232 (SwimmingSeadragon)
  AucStatStdDev, v8.1.6233 (SwimmingSeadragon)
  AucUtilFixAH, v8.1.6235 (SwimmingSeadragon)
  BeanCounter, v8.1.6236 (SwimmingSeadragon)
  Enchantrix, v8.1.6237 (SwimmingSeadragon)
  FishingBuddy, v1.9.30.1
  GatherMate2, v1.43.6
  GFWFactionFriend, v8.1.5
  Informant, v8.1.6246 (SwimmingSeadragon)
  Recount, vv8.1.5b
  SlideBar, v8.1.6239 (SwimmingSeadragon)
  Stubby, v8.1.6240 (SwimmingSeadragon)
  BlizRuntimeLib_enUS v8.1.5.80100 <none>
  (ck=329)
Date: 2019-06-12 18:08:30
ID: -1
Error occured in: AddOn: GFW_FactionFriend
Count: 1
Message: Note: AddOn GFW_FactionFriend attempted to call a protected function (VerticalMultiBarsContainer:SetPoint()) during combat lockdown.
Debug:
   [C]: SetPoint()
   ..\FrameXML\MultiActionBars.lua:94: MultiActionBar_Update()
   ..\FrameXML\ActionBarController.lua:169: ValidateActionBarTransition()
   ..\FrameXML\ActionBarController.lua:137: ActionBarController_UpdateAll()
   ..\FrameXML\ActionBarController.lua:62:
      ..\FrameXML\ActionBarController.lua:51
Locals:
None
AddOns:
  Swatter, v8.1.6241 (SwimmingSeadragon)
  AdvancedInterfaceOptions, v1.2.11
  AucAdvanced, v8.1.6201 (SwimmingSeadragon)
  AucFilterBasic, v8.1.6228 (SwimmingSeadragon)
  AucStatHistogram, v8.1.6230 (SwimmingSeadragon)
  AucStatiLevel, v8.1.6234 (SwimmingSeadragon)
  AucStatPurchased, v8.1.6231 (SwimmingSeadragon)
  AucStatSimple, v8.1.6232 (SwimmingSeadragon)
  AucStatStdDev, v8.1.6233 (SwimmingSeadragon)
  AucUtilFixAH, v8.1.6235 (SwimmingSeadragon)
  BeanCounter, v8.1.6236 (SwimmingSeadragon)
  Enchantrix, v8.1.6237 (SwimmingSeadragon)
  FishingBuddy, v1.9.30.1
  GatherMate2, v1.43.6
  GFWFactionFriend, v8.1.5
  Informant, v8.1.6246 (SwimmingSeadragon)
  Recount, vv8.1.5b
  SlideBar, v8.1.6239 (SwimmingSeadragon)
  Stubby, v8.1.6240 (SwimmingSeadragon)
  BlizRuntimeLib_enUS v8.1.5.80100 <none>
  (ck=329)
ShaunaGordon commented 5 years ago

These all seem to tie back to trying to set a protected function (usually SetPoint()) on combat lockdown. I've stumbled across another way to trigger it -- any quest with an item you have to use that shows up on the quest tracker HUD, it will trigger the error when going to use the item, then prevent being able to use the item from the quest tracking HUD. I had to put the item on my actual bars to be able to use it.

Specifically, I found it during the It Belongs In My Mech quest and found that when I tried to use the Azerite Vacuumizer, I got an error triggered by Faction Friend, then clicking on the AV button in the HUD did nothing.

I've got multiple errors from FF, and while the originating object differs (Boss1TargetFrame, MainMenuBar, VerticalMultiBars, VerticalMultiBarsContainer, etc), it's nearly always either SetPoint() or ClearAllPoints() functions, though I'm also seeing SetScale() and SetSize().

Additionally, I'm seeing odd behavior when switching between a vehicle and the regular interface that I wasn't seeing before I installed FF, though I haven't yet confirmed if this is due to FF (I think it's a symptom of an issued caused by PetActionButtonX.hide() getting called on combat lockdown). The animation will repeat several times before finally switching back to normal. I can most reliably re-create this on the Cycle of Life world quests, particularly the ones where the player is the crab, though I suspect any vehicle (particularly vehicle + combat) is likely to reproduce it.

ShaunaGordon commented 5 years ago

I've been lurking in Norganna's Slack (Auctioneer) and someone mentioned this, which I think might be relevant.

It is necessary to do a search/replace and take every instance of GameTooltip:SetPoint() and replace with GameTooltip:SetOwner().

Sometimes you have GameTooltip:SetOwner(self, "ANCHOR_NONE"); GameTooltip:SetPoint("TOPLEFT", self, "BOTTOMRIGHT"); this now becomes GameTooltip:SetOwner(self,"ANCHOR_BOTTOMRIGHT");

He's talking about tooltips, but I think the same principle applies here, too.

ShaunaGordon commented 5 years ago

Further digging suggests this may be a tainting issue. While some tainting can be ignored (like ElvUI has chosen to do for some of the errors), I don't think this can be ignored due to the aforementioned issue with being able to use quest items.

I'm continuing to dig, because I'm bound and determined to get this running again for BfA:RoA.