search

fizzyizzy05 / binary

Small and simple app to convert numbers to a different base.
https://flathub.org/apps/io.github.fizzyizzy05.binary
GNU General Public License v3.0
11 stars 7 forks source link

A big PR to fix many things #6

Closed ghost closed 6 months ago

ghost commented 6 months ago

Please review individually,

fizzyizzy05 commented 6 months ago

This all looks good and reasonable. LGTM. Thank you!

fizzyizzy05 commented 6 months ago

I've added you to the Translator credits using the name you used on GitHub. Please let me know if you want this changed, or reverted. 1788dd3

ghost commented 6 months ago

This string changes via the po files. Actually you have broken it.

https://github.com/fizzyizzy05/binary/blob/main/po/tr.po#L67-L70

fizzyizzy05 commented 6 months ago

that's weird, without it the translation credits are empty: image

ghost commented 6 months ago

it is locale centric and will be visible to corresponding language.

fizzyizzy05 commented 6 months ago

Okay then, I'll revert this!