Is it possible to remove dependency on TAlib?

[tombohub]

TAlib is problematic to install on ubuntu and especially on windows which I still didn't figure out how.

Is it possible to install and use pinkfish without TAlib?

[fja05680]

Hello,

Yes. You should be able to comment out the TA-lib import within indicators.py. The CROSSOVER indicator uses TA-lib, so you should comment out that indicator. It should work from there without having TA-lib installed. You'll also need to remove TA-lib from requirements.txt. Many of the examples depend on the CROSSOVER indicator though.

This does give me an idea. I'm going to look into rolling my own moving average functions so that the dependency on TA-lib can be removed for the CROSSOVER indicator. From there, I should be able to create a pip package for pinkfish, which will make installing pinkfish just as easy as any other python project. Then TA-lib can just be an addition, but not required. This will take some time though that I currently don't have. Stay tuned.

In the mean time. Please look at my installation video on youtube. I demonstrate exactly how to set up pinkfish with TA-lib on Ubuntu. If you follow those instructions exactly, you should have no problems.

Farrell

[tombohub]

Hi, thanks I'll do that! Did you try some other indicators package?

Great news with going to pip package, that will make installation much easier

[fja05680]

tombohub,

Thanks for bring up this issue. I just removed the ta-lib dependency for pinkfish API.

Farrell

[paulmcq]

README.md typos?? I still recommend that later you get ta-lib installed so that you can run all the examples, some of which depend on pinkfish ta-lib. Also, this opens up the likelyhood likelihood that I can soon release a pinkfish version that can be installed with pip.

On Thu, Nov 4, 2021 at 3:48 AM Farrell Aultman @.***> wrote:

tombohub,

Thanks for bring up this issue. I just removed the ta-lib dependency for pinkfish API.

Farrell

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960560503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3AQGKIVY4TPPVHDVU4OWDUKJJHTANCNFSM5GKO4YLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[fja05680]

Yes it should just say ta-iib not pinkfish ta-lib. There is no such thing as pinkfish ta-lib. Thanks for finding this error.

On Thu, Nov 4, 2021, 9:26 AM paulmcq @.***> wrote:

README.md typos?? I still recommend that later you get ta-lib installed so that you can run all the examples, some of which depend on pinkfish ta-lib. Also, this opens up the likelyhood likelihood that I can soon release a pinkfish version that can be installed with pip.

On Thu, Nov 4, 2021 at 3:48 AM Farrell Aultman @.***> wrote:

tombohub,

Thanks for bring up this issue. I just removed the ta-lib dependency for pinkfish API.

Farrell

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960560503, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AD3AQGKIVY4TPPVHDVU4OWDUKJJHTANCNFSM5GKO4YLQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960924440, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD3KHVZV3VYZQOMR4HHRT3UKKCZXANCNFSM5GKO4YLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[fja05680]

Yes and I noticed another typo there. I did this in the wee hours last night. I'll fix it in a little bit thanks.

On Thu, Nov 4, 2021, 9:26 AM paulmcq @.***> wrote:

README.md typos?? I still recommend that later you get ta-lib installed so that you can run all the examples, some of which depend on pinkfish ta-lib. Also, this opens up the likelyhood likelihood that I can soon release a pinkfish version that can be installed with pip.

On Thu, Nov 4, 2021 at 3:48 AM Farrell Aultman @.***> wrote:

tombohub,

Thanks for bring up this issue. I just removed the ta-lib dependency for pinkfish API.

Farrell

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960560503, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AD3AQGKIVY4TPPVHDVU4OWDUKJJHTANCNFSM5GKO4YLQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960924440, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD3KHVZV3VYZQOMR4HHRT3UKKCZXANCNFSM5GKO4YLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[paulmcq]

BTW, I agree muchly that if pinkfish was able to be installed via pip it would help a lot. For example, me: I have not tried pinkfish just because I do not understand the effects on my virtualenvs if I tried to install it without using pip :-(

On Thu, Nov 4, 2021 at 8:49 AM Farrell Aultman @.***> wrote:

Yes it should just say ta-iib not pinkfish ta-lib. There is no such thing as pinkfish ta-lib. Thanks for finding this error.

On Thu, Nov 4, 2021, 9:26 AM paulmcq @.***> wrote:

README.md typos?? I still recommend that later you get ta-lib installed so that you can run all the examples, some of which depend on pinkfish ta-lib. Also, this opens up the likelyhood likelihood that I can soon release a pinkfish version that can be installed with pip.

On Thu, Nov 4, 2021 at 3:48 AM Farrell Aultman @.***> wrote:

tombohub,

Thanks for bring up this issue. I just removed the ta-lib dependency for pinkfish API.

Farrell

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/fja05680/pinkfish/issues/48#issuecomment-960560503 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AD3AQGKIVY4TPPVHDVU4OWDUKJJHTANCNFSM5GKO4YLQ

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960924440, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACD3KHVZV3VYZQOMR4HHRT3UKKCZXANCNFSM5GKO4YLQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/issues/48#issuecomment-960970643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3AQGLCCYECUX37BKVAV6LUKKFOVANCNFSM5GKO4YLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[fja05680]

I'll try to get a pip install within the next couple weeks. I my even try it out on Windows. I've been hesitant to make a pip version available for two reasons: pinkfish was under heavy development, and there was no easy way to install ta-lib. Both of these concerns are now out of the way.