search

fja05680 / pinkfish

A backtester and spreadsheet library for security analysis.
https://fja05680.github.io/pinkfish
MIT License
264 stars 60 forks source link

Tomo #78

Closed tombohub closed 6 months ago

tombohub commented 7 months ago

Pinkfish still required TA-Lib when pip install pinkfish . It's supposed to be only in extras

tombohub commented 7 months ago

vscode python extension uses black which automatically formats code

fja05680 commented 7 months ago

Thanks for the heads up I'll check into that as well when I do the update.

On Mon, Dec 11, 2023, 5:50 PM tombohub @.***> wrote:

Pinkfish still required TA-Lib when pip install pinkfish . It's supposed to be only in extras

You can view, comment on, or merge this pull request online at:

https://github.com/fja05680/pinkfish/pull/78 Commit Summary

File Changes

(2 files https://github.com/fja05680/pinkfish/pull/78/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/pull/78, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD3KHSIISILN2IPQYEUPBLYI6L4PAVCNFSM6AAAAABAQSOFZCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTMNZSG4ZTAMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fja05680 commented 6 months ago

vscode python extension uses black which automatically formats code

Good to know. Generally, i think code formatters are good for large projects with many contributors. I like the code a certain way though and since it's mostly just me, I don't use one for pinkfish.

tombohub commented 6 months ago

Ok, it was auto format on save so I didn't notice. Do you want me to make another pull without code formatting?

fja05680 commented 6 months ago

No, just wait. I'm in the process of updating everything.

On Thu, Dec 21, 2023, 10:41 AM tombohub @.***> wrote:

Ok, it was auto format on save so I didn't notice. Do you want me to make another pull without code formatting?

— Reply to this email directly, view it on GitHub https://github.com/fja05680/pinkfish/pull/78#issuecomment-1866624329, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD3KHUH36EXPMJMBPUSIDDYKRRFJAVCNFSM6AAAAABAQSOFZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWGYZDIMZSHE . You are receiving this because you commented.Message ID: @.***>