fjansson / MorphoSnake

Thallus and leaf morphometry in Python
GNU General Public License v3.0
9 stars 6 forks source link

Incompatible with networkx 2.0 #1

Open fjansson opened 6 years ago

fjansson commented 6 years ago

MorphoSnake currently depends on NetworkX 1.x and is not compatible with 2.0 which is already included in some Linux distributions.

The NetworkX Manual](https://networkx.github.io/documentation/stable/release/migration_guide_from_1.x_to_2.0.html) has a section on migrating to be compatible with both versions. This would be the best, as version 1.x will probably be around for a while in older distributions.

Workaround: pip3 install 'networkx<2.0', preferrably in a virtual environment.

Reported by Bernard Billoud.

RoqueGio commented 5 years ago

Hi, I added compatibility with NetworkX 2.x while keeping it compatible with 1.x.

morphosnake.py.zip

reeb commented 5 years ago

Thanks

Le mer. 27 févr. 2019 à 17:56, RoqueGio notifications@github.com a écrit :

Hi, I added compatibility with NetworkX 2.x while keeping it compatible with 1.x.

morphosnake.py.zip https://github.com/fjansson/MorphoSnake/files/2911371/morphosnake.py.zip

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fjansson/MorphoSnake/issues/1#issuecomment-467942348, or mute the thread https://github.com/notifications/unsubscribe-auth/AGi0AeO5BxdL_gHZDG47MAAQuqU69DX0ks5vRri0gaJpZM4Q9aq8 .

-- Catherine Reeb

alternative email: catherine.reeb@mnhn.fr

fjansson commented 5 years ago

Thanks @RoqueGio ! I made a pull request from your repository, and merged it. Feel free to submit pull requests yourself if you make any further improvements.

reeb commented 5 years ago

Hye Fredrik

Thanks for information, is it the last version proposed by the young team of last year ? The software was really improved with many new features, I think I sent you their presentation in french, you may see a lot of new features

https://github.com/Manuel-Mockus/MorphoSnake-1

I am not so good with github, the est will be to join the old and new ?

Le sam. 2 mars 2019 à 18:35, Fredrik Jansson notifications@github.com a écrit :

Thanks @RoqueGio https://github.com/RoqueGio ! I made a pull request from your repository, and merged it. Feel free to submit pull requests yourself if you make any further improvements.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fjansson/MorphoSnake/issues/1#issuecomment-468941762, or mute the thread https://github.com/notifications/unsubscribe-auth/AGi0ATywl1Eh9bHwMlDONldlD_2Uwz9Gks5vSrZEgaJpZM4Q9aq8 .

reeb commented 5 years ago

Hye RoqueGio

Thanks for you update, Last year a team of 3 students in math-info improved tha first version. I send you the repository; we need to make an update. It works very well, I testedit on new biologicla material (alga)

https://github.com/Manuel-Mockus/MorphoSnake-1

I also send you their presentation in french, where you et the new possibilities (move nodes, insert new nodes etc.) a try for superposition treatment etc. I can translate some points if needed

Catherine Reeb

Catherine Reeb -- MADBRYO - Bryophytes from Madagascar project https://www.madbryo.org BRYOTAN - Bryophytes from Antananarivo Herbarium GBIF BID https://www.bryotan.com

Institut de Systématique Évolution Biodiversité (ISYEB) UMR 7205 - Sorbonne Université - MNHN - CNRS - EPHE 57 rue Cuvier BP 39 75005 - Paris - FRANCE mobile phone : +33629375132 office: +33140793200 Web page Catherine Reeb ISYEB http://isyeb.mnhn.fr/annuaire-et-pages-personnelles/pages-personnelles/reeb-catherine?lang=fr alternative email : catherine.reeb@gmail.com

Le mer. 27 févr. 2019 à 17:56, RoqueGio notifications@github.com a écrit :

Hi, I added compatibility with NetworkX 2.x while keeping it compatible with 1.x.

morphosnake.py.zip https://github.com/fjansson/MorphoSnake/files/2911371/morphosnake.py.zip

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fjansson/MorphoSnake/issues/1#issuecomment-467942348, or mute the thread https://github.com/notifications/unsubscribe-auth/AGi0AeO5BxdL_gHZDG47MAAQuqU69DX0ks5vRri0gaJpZM4Q9aq8 .