search

fjaros / cleangroupassigns

World of Warcraft Classic Addon to automatically sort your raid based on your preset arrangements.
GNU General Public License v3.0
3 stars 3 forks source link

Small improvements (v1.8) #9

Open Road-block opened 3 years ago

Road-block commented 3 years ago

I thought this addon was in hiatus why I didn't bother opening tickets earlier 😊

Functions that rely on valid results from GetGuildRosterInfo and GetRaidRosterInfo have been occasionally erroring in the past shortly after PLAYER_ENTERING_WORLD (either initial login or crossing loading screens) as both of those methods have a chance to not return valid results.

I had fixed that in my local copy by checking for valid returns in lines 93, 103 and 467 thus:

if tmpName and tmpName ~= _G.UNKNOWNOBJECT then

and 

if name and name ~= _G.UNKNOWNOBJECT then

respectively.

A small cosmetic change I've also made to my local copy was around line 1025 replacing

self.f:SetTitle("<clean> group assignments")

with this small block.

local guild_name = IsInGuild() and (GetGuildInfo("player"))
self.f:SetTitle(guild_name and "<"..guild_name.."> group assignments" or "<clean> group assignments")

Finally an actual feature request.

Reuse the dropdown in the Player Bank that currently only has a Delete menu item to save a raid mark on that player (💀 , ❌ etc) and have rearrange, apply those marks.

Use case: We use marks to arrange subgroups for a bunch of encounters (and is something that will likely continue in the future) eg. C'Thun pie slices, 4HM dps groups and so on.

fjaros commented 3 years ago

hey. always nice to hear from you :) yeah the addon was technically in hiatus but in https://github.com/fjaros/cleangroupassigns/issues/7 tobbi007 was kind enough to write a contribution so I felt like helping him out.

PLAYER_ENTERING_WORLD -> good catch. I think those functions become available only after receiving the first GUILD_ROSTER_UPDATE or PLAYER_GUILD_UPDATE which signal to the addon that the data has been populated for those APIs in the client. it's a minor issue but probably worthwhile to patch in the next update (if there is one).

cosmetic change -> but my guild needs a shoutout :p

raid markers in right click -> good suggestion, that's definitely doable. as always, feel free to make a PR or i'll get to it the next time i feel like resurrecting the project.