fjaros / wowchat

WoWChat is a clientless Discord integration chat bot for old versions of World of Warcraft.
GNU General Public License v3.0
139 stars 96 forks source link

Guild Notifications custom channels not working as intended. #110

Closed ghost closed 11 months ago

ghost commented 11 months ago

I have edited the config to something like the below:

guild {
  online {
    enabled=1
    format="`[%user] has come online.`"
    channel=guild-log
  }
  offline {
    enabled=1
    format="`[%user] has gone offline.`"
    channel=guild-log
  }
  promoted {
    enabled=1
    format="`[%user] has promoted [%target] to [%rank].`"
    channel=guild-log
  }
  demoted {
    enabled=1
    format="`[%user] has demoted [%target] to [%rank].`"
    channel=guild-log
  }
  joined {
    enabled=1
    format="`[%user] has joined the guild.`"
    channel=guild-log
  }
  left {
    enabled=1
    format="`[%user] has left the guild.`"
    channel=guild-log
  }
  removed {
    enabled=1
    format="`[%target] has been kicked out of the guild by [%user].`"
    channel=guild-log
  }
  motd {
    enabled=0
    format="`Guild Message of the Day: %message`"
    channel=guild-log
  }
  achievement {
    enabled=0
    format="%user has earned the achievement %achievement!"
    channel=guild-log
  }
}

What I noticed is offline is the only one to post in the guild-log channel. So I did a few tests and made it so online was the only one with the custom channel which online then posted in the custom channel, so I added offline as well and what I ended up seeing is offline was the only one to post in the custom channel and online started posting in the guild chat channel.

it seems there is some bug in the code that handled the guild notifs config and only allows 1 of the items to use a custom channel.

fjaros commented 11 months ago

Fixed in https://github.com/fjaros/wowchat/commit/87ccb320d1a1383b7b088c0acbf36715e19cfa67 . Can you download the latest release zip and try again? Thanks

ghost commented 11 months ago

yep will build shortly and try it out

On Fri, Oct 6, 2023 at 6:53 PM Filip Jaroš @.***> wrote:

Fixed in 87ccb32 https://github.com/fjaros/wowchat/commit/87ccb320d1a1383b7b088c0acbf36715e19cfa67 . Can you download the latest release zip and try again? Thanks

— Reply to this email directly, view it on GitHub https://github.com/fjaros/wowchat/issues/110#issuecomment-1751480510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVWES7Z6U5KWSWSSQS2FFRLX6CDWPAVCNFSM6AAAAAA5WM5K2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGQ4DANJRGA . You are receiving this because you authored the thread.Message ID: @.***>

ghost commented 11 months ago

@fjaros that was fast! it works as it should now! Thank you