fjaros / wowchat

WoWChat is a clientless Discord integration chat bot for old versions of World of Warcraft.
GNU General Public License v3.0
139 stars 96 forks source link

customizeble db link in confFile #81

Closed janeblower closed 2 years ago

fjaros commented 2 years ago

nice but have you even tried compiling this? you didn't implement actually adding the field database to the config class, and also you deleted MessageResolverCataclysm which is implemented by MessageResolverMoP.

once you fix that, I would recommend keeping the hardcoded values as the defaults. because otherwise using the existing wowchat.conf will fail with the new version. to do that you can implement the field database as an Option and then do database.getOrElse("default db link") in MessageResolver classes.