search

fjarri / reikna

Pure Python GPGPU library
http://reikna.publicfields.net/
MIT License
164 stars 16 forks source link

Different `funcsigs` version minimums #66

Closed jakirkham closed 4 months ago

jakirkham commented 1 year ago

Noticed there are 2 different funcsigs version minimums in the project. Wasn't sure which should be used or whether they should match

https://github.com/fjarri/reikna/blob/e2bc3eac698ac7e0218544dd49a25ab292312e69/setup.py#L132

https://github.com/fjarri/reikna/blob/e2bc3eac698ac7e0218544dd49a25ab292312e69/requirements.txt#L2

fjarri commented 1 year ago

Yeah, it's weird. That line in setup.py was changed 9 years ago, and requirements.txt 8 years ago, so I don't really remember how it came to be. I suspect anything >= 0.3 would work. Does it cause any problems?

I'm reluctant to fix this since I'm working on switching the backend to grunnur which will obsolete this requirement anyway.

jakirkham commented 1 year ago

This would be my guess as well.

Sadly I'm not sure. Was noticing this when updating the conda-forge package recently. Suspect users are picking up latest funcsigs, which is 1.0.2. So haven't heard any complaints.

Yeah that seems fair.