Change (id) to (instancetype)

fjcaetano / NSStringMask

NSStringMask allows you to apply masks or formats to NSStrings using NSRegularExpression to input your format.

http://fjcaetano.github.io/NSStringMask/

MIT License

241 stars 36 forks source link

Change (id) to (instancetype) #10

Closed swilliams closed 9 years ago

swilliams commented 9 years ago

This library is exactly what I was looking for. Nice job. I noticed that most of the initializers returned id though instead of the recommended instancetype. This PR just changes that. Tests passed locally.

swilliams commented 9 years ago

Looks like there is a Travis config issue.

$ brew install xctool
Error: xctool-0.2.1 already installed
To install this version, first `brew unlink xctool'
The command "brew install xctool" failed and exited with 1 during .

fjcaetano commented 9 years ago

Don't worry, I'll take a look. There's a long time since this was updated, maybe something is deprecated. Since you only changed the methods' contracts, there's no reason why these tests would fail.